<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;"> <p>I don't have rev0 hardware. I can edit the comment but I can't test the switch to the logic.</p> <p><br> </p> <p>Is there even rev0 hardware in retail?</p> <p><br> </p> <p>Tom</p> <br> <br> <div style="color: rgb(0, 0, 0);"> <div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Alex Deucher <alexdeucher@gmail.com><br> <b>Sent:</b> Tuesday, July 26, 2016 14:47<br> <b>To:</b> Tom St Denis<br> <b>Cc:</b> amd-gfx list; StDenis, Tom<br> <b>Subject:</b> Re: [PATCH 2/4] drm/amd/amdgpu: Add GFX and UVD PG for Carrizo</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">On Tue, Jul 26, 2016 at 11:38 AM, Tom St Denis <tstdenis82@gmail.com> wrote:<br> > Enables GFX PG and UVD static PG on Carrizo class<br> > asics.<br> ><br> > Signed-off-by: Tom St Denis <tom.stdenis@amd.com><br> > ---<br> > drivers/gpu/drm/amd/amdgpu/vi.c | 9 +++++++++<br> > 1 file changed, 9 insertions(+)<br> ><br> > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c<br> > index 9ba64989f092..289a4c4ac9e7 100644<br> > --- a/drivers/gpu/drm/amd/amdgpu/vi.c<br> > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c<br> > @@ -1578,7 +1578,16 @@ static int vi_common_early_init(void *handle)<br> > AMD_CG_SUPPORT_HDP_LS |<br> > AMD_CG_SUPPORT_SDMA_MGCG |<br> > AMD_CG_SUPPORT_SDMA_LS;<br> > + /* rev0 hardware doesn't support PG */<br> <br> It's probably worth correcting this comment. A0 theoretically<br> supports PG, but probably requires additional workarounds. Something<br> like "Don't enable PG on rev0 hw due to hw issues" or something like<br> that.<br> <br> > adev->pg_flags = 0;<br> > + if (adev->rev_id != 0x00) {<br> > + adev->pg_flags |= AMD_PG_SUPPORT_GFX_PG |<br> > + AMD_PG_SUPPORT_GFX_SMG |<br> > + AMD_PG_SUPPORT_GFX_PIPELINE;<br> > + /* powerplay UVD PG doesn't work yet */<br> > + if (!amdgpu_powerplay)<br> > + adev->pg_flags |= AMD_PG_SUPPORT_UVD;<br> <br> It's probably worth testing UVD PG on rev0 hw as well so see if we can<br> enable this on them as well. OTOH, there isn't likely much rev0 hw in<br> the wild, so it may not matter too much.<br> <br> Alex<br> <br> > + }<br> > adev->external_rev_id = adev->rev_id + 0x1;<br> > break;<br> > case CHIP_STONEY:<br> > --<br> > 2.9.2<br> ><br> > _______________________________________________<br> > amd-gfx mailing list<br> > amd-gfx@lists.freedesktop.org<br> > <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk975737"> https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <div id="LPBorder_GT_14695589164750.4512743390541143" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;"> <table id="LPContainer_14695589164710.07989852876321746" cellspacing="0" style="width: 90%; position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200); background-color: rgb(255, 255, 255);"> <tbody> <tr valign="top" style="border-spacing: 0px;"> <td id="TextCell_14695589164730.6199863572278035" colspan="2" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;"> <div id="LPRemovePreviewContainer_14695589164730.49146283525099066"></div> <div id="LPTitle_14695589164730.09316000362307508" style="top: 0px; color: rgb(59, 87, 119); font-weight: normal; font-size: 21px; font-family: wf_segoe-ui_light, "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;"> <a id="LPUrlAnchor_14695589164730.8951956216594377" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank" style="text-decoration: none;">amd-gfx Info Page - lists.freedesktop.org</a></div> <div id="LPMetadata_14695589164740.8299894332593494" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;"> lists.freedesktop.org</div> <div id="LPDescription_14695589164740.743527748320729" style="display: block; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;"> To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...</div> </td> </tr> </tbody> </table> </div> <br> <br> </div> </span></font></div> </div> </body> </html>