<div dir="ltr"><div>Just early engineering samples are rev0.<br><br></div>Alex<br><div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 26, 2016 at 2:49 PM, StDenis, Tom <span dir="ltr"><<a href="mailto:Tom.StDenis@amd.com" target="_blank">Tom.StDenis@amd.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div style="font-size:12pt;color:#000000;background-color:#ffffff;font-family:Calibri,Arial,Helvetica,sans-serif">
<p>I don't have rev0 hardware. I can edit the comment but I can't test the switch to the logic.</p>
<p><br>
</p>
<p>Is there even rev0 hardware in retail?</p>
<p><br>
</p>
<p>Tom</p>
<br>
<br>
<div style="color:rgb(0,0,0)">
<div>
<hr style="display:inline-block;width:98%">
<div dir="ltr"><font style="font-size:11pt" color="#000000" face="Calibri, sans-serif"><b>From:</b> Alex Deucher <<a href="mailto:alexdeucher@gmail.com" target="_blank">alexdeucher@gmail.com</a>><br>
<b>Sent:</b> Tuesday, July 26, 2016 14:47<br>
<b>To:</b> Tom St Denis<br>
<b>Cc:</b> amd-gfx list; StDenis, Tom<br>
<b>Subject:</b> Re: [PATCH 2/4] drm/amd/amdgpu: Add GFX and UVD PG for Carrizo</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt">
<div><div><div class="h5">On Tue, Jul 26, 2016 at 11:38 AM, Tom St Denis <<a href="mailto:tstdenis82@gmail.com" target="_blank">tstdenis82@gmail.com</a>> wrote:<br>
> Enables GFX PG and UVD static PG on Carrizo class<br>
> asics.<br>
><br>
> Signed-off-by: Tom St Denis <<a href="mailto:tom.stdenis@amd.com" target="_blank">tom.stdenis@amd.com</a>><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/vi.c | 9 +++++++++<br>
> 1 file changed, 9 insertions(+)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c<br>
> index 9ba64989f092..289a4c4ac9e7 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/vi.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/vi.c<br>
> @@ -1578,7 +1578,16 @@ static int vi_common_early_init(void *handle)<br>
> AMD_CG_SUPPORT_HDP_LS |<br>
> AMD_CG_SUPPORT_SDMA_MGCG |<br>
> AMD_CG_SUPPORT_SDMA_LS;<br>
> + /* rev0 hardware doesn't support PG */<br>
<br>
It's probably worth correcting this comment. A0 theoretically<br>
supports PG, but probably requires additional workarounds. Something<br>
like "Don't enable PG on rev0 hw due to hw issues" or something like<br>
that.<br>
<br>
> adev->pg_flags = 0;<br>
> + if (adev->rev_id != 0x00) {<br>
> + adev->pg_flags |= AMD_PG_SUPPORT_GFX_PG |<br>
> + AMD_PG_SUPPORT_GFX_SMG |<br>
> + AMD_PG_SUPPORT_GFX_PIPELINE;<br>
> + /* powerplay UVD PG doesn't work yet */<br>
> + if (!amdgpu_powerplay)<br>
> + adev->pg_flags |= AMD_PG_SUPPORT_UVD;<br>
<br>
It's probably worth testing UVD PG on rev0 hw as well so see if we can<br>
enable this on them as well. OTOH, there isn't likely much rev0 hw in<br>
the wild, so it may not matter too much.<br>
<br>
Alex<br>
<br>
> + }<br>
> adev->external_rev_id = adev->rev_id + 0x1;<br>
> break;<br>
> case CHIP_STONEY:<br>
> --<br>
> 2.9.2<br>
><br>
> _______________________________________________<br>
> amd-gfx mailing list<br>
> <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank">
https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
</div></div><div style="margin-bottom:20px;overflow:auto;width:100%;text-indent:0px">
<table style="width:90%;overflow:auto;padding-top:20px;padding-bottom:20px;margin-top:20px;border-top:1px dotted rgb(200,200,200);border-bottom:1px dotted rgb(200,200,200);background-color:rgb(255,255,255)" cellspacing="0">
<tbody>
<tr style="border-spacing:0px" valign="top">
<td colspan="2" style="vertical-align:top;padding:0px;display:table-cell">
<div></div>
<div style="color:rgb(59,87,119);font-weight:normal;font-size:21px;font-family:wf_segoe-ui_light,"Segoe UI Light","Segoe WP Light","Segoe UI","Segoe WP",Tahoma,Arial,sans-serif;line-height:21px">
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" style="text-decoration:none" target="_blank">amd-gfx Info Page - lists.freedesktop.org</a></div>
<div style="margin:10px 0px 16px;color:rgb(102,102,102);font-weight:normal;font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif;font-size:14px;line-height:14px">
<a href="http://lists.freedesktop.org" target="_blank">lists.freedesktop.org</a></div>
<div style="display:block;color:rgb(102,102,102);font-weight:normal;font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif;font-size:14px;line-height:20px;max-height:100px;overflow:hidden">
To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...</div>
</td>
</tr>
</tbody>
</table>
</div>
<br>
<br>
</div>
</span></font></div>
</div>
</div>
</blockquote></div><br></div></div></div></div></div>