<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>Hi Alex,</p>
<p><br>
</p>
<p>Ok, a similar change was introduced for UVD in <span>7a6526488b60283cec91852196a5423b1dfb14d8, should that be reverted in part too?</span></p>
<p><span><br>
</span></p>
<p><span>Tom</span></p>
<br>
<br>
<div style="color: rgb(0, 0, 0);">
<div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Deucher, Alexander<br>
<b>Sent:</b> Wednesday, August 3, 2016 12:27<br>
<b>To:</b> 'Tom St Denis'; amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> StDenis, Tom<br>
<b>Subject:</b> RE: [PATCH 4/6] drm/amd/amdgpu: Move VCE bypass after MGCG test</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">> -----Original Message-----<br>
> From: amd-gfx [<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">mailto:amd-gfx-bounces@lists.freedesktop.org</a>] On Behalf<br>
> Of Tom St Denis<br>
> Sent: Wednesday, August 03, 2016 11:52 AM<br>
> To: amd-gfx@lists.freedesktop.org<br>
> Cc: StDenis, Tom<br>
> Subject: [PATCH 4/6] drm/amd/amdgpu: Move VCE bypass after MGCG test<br>
> <br>
> Only issue bypass if MGCG enabled<br>
<br>
NACK. We need this for Polaris right now since we don't enable CG yet and setting bypass mode saves power.<br>
<br>
Alex<br>
<br>
> <br>
> Signed-off-by: Tom St Denis <tom.stdenis@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 6 +++---<br>
> 1 file changed, 3 insertions(+), 3 deletions(-)<br>
> <br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c<br>
> b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c<br>
> index 9d1924e4e2bc..63c9efefa583 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c<br>
> @@ -769,12 +769,12 @@ static int vce_v3_0_set_clockgating_state(void<br>
> *handle,<br>
> bool enable = (state == AMD_CG_STATE_GATE) ? true : false;<br>
> int i;<br>
> <br>
> - if (adev->asic_type == CHIP_POLARIS10)<br>
> - vce_v3_set_bypass_mode(adev, enable);<br>
> -<br>
> if (!(adev->cg_flags & AMD_CG_SUPPORT_VCE_MGCG))<br>
> return 0;<br>
> <br>
> + if (adev->asic_type == CHIP_POLARIS10)<br>
> + vce_v3_set_bypass_mode(adev, enable);<br>
> +<br>
> mutex_lock(&adev->grbm_idx_mutex);<br>
> for (i = 0; i < 2; i++) {<br>
> /* Program VCE Instance 0 or 1 if not harvested */<br>
> --<br>
> 2.9.2<br>
> <br>
> _______________________________________________<br>
> amd-gfx mailing list<br>
> amd-gfx@lists.freedesktop.org<br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
</div>
</body>
</html>