<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> I’m not sure what the specific features are that are causing issues. FWIW, the first KFDTest unit test that fails has the CPU wait for the GPU to signal 256 events using PM4ReleaseMemory packets. It uses IOMMUv2 for coherent memory access from the GPU.<o:p></o:p> <o:p> </o:p> Regards,<o:p></o:p> Felix<o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> From: Deucher, Alexander Sent: Monday, August 08, 2016 2:04 PM To: StDenis, Tom; Kuehling, Felix; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 09/14] drm/amd/amdgpu: Enable carrizo GFX PG<o:p></o:p> </div> </div> <o:p> </o:p> I'm not sure gfx PG works properly with some of the kfd features. I know there were problems in the past. We probably need to add some sort of handshake for when we have kfd running in order to disable gfx PG when necessary.<o:p></o:p> <o:p> </o:p> Alex<o:p></o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> From: amd-gfx [<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">mailto:amd-gfx-bounces@lists.freedesktop.org</a>] On Behalf Of StDenis, Tom Sent: Monday, August 08, 2016 1:59 PM To: Kuehling, Felix; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> Subject: Re: [PATCH 09/14] drm/amd/amdgpu: Enable carrizo GFX PG<o:p></o:p> </div> </div> <o:p> </o:p> <div id="divtagdefaultwrapper"> Hi Felix, <o:p></o:p> <o:p> </o:p> Hmm, it's unfortunate because I haven't been able to reproduce any hangs on my AM4 based Carrizo. What specific tests are you running when it hangs?<o:p></o:p> <o:p> </o:p> Cheers,<o:p></o:p> Tom<o:p></o:p> <o:p> </o:p> <div> <div> <div class="MsoNormal" align="center" style="text-align:center;background:white"> <hr size="2" width="98%" align="center"> </div> <div id="x_divRplyFwdMsg"> From: Kuehling, Felix Sent: Monday, August 8, 2016 13:57 To: <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>; StDenis, Tom Subject: Re: [PATCH 09/14] drm/amd/amdgpu: Enable carrizo GFX PG <o:p></o:p> <div> <o:p></o:p> </div> </div> </div> <div> We're reverting this commit on the KFD branch because it's causing hangs on a bunch of HSA compute tests on CZ. Regards, Felix On 16-07-28 10:19 AM, Tom St Denis wrote: > Signed-off-by: Tom St Denis <<a href="mailto:tom.stdenis@amd.com">tom.stdenis@amd.com</a>> > --- > drivers/gpu/drm/amd/amdgpu/vi.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c > index 9ba64989f092..4fa9fea541a5 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vi.c > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c > @@ -1578,7 +1578,13 @@ static int vi_common_early_init(void *handle) > AMD_CG_SUPPORT_HDP_LS | > AMD_CG_SUPPORT_SDMA_MGCG | > AMD_CG_SUPPORT_SDMA_LS; > + /* rev0 hardware requires workarounds to support PG */ > adev->pg_flags = 0; > + if (adev->rev_id != 0x00) { > + adev->pg_flags |= AMD_PG_SUPPORT_GFX_PG | > + AMD_PG_SUPPORT_GFX_SMG | > + AMD_PG_SUPPORT_GFX_PIPELINE; > + } > adev->external_rev_id = adev->rev_id + 0x1; > break; > case CHIP_STONEY:<o:p></o:p> </div> </div> </div> </div> </div> </body> </html>