<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;"> <p>Hi Felix, </p> <p><br> </p> <p>Hmm, it's unfortunate because I haven't been able to reproduce any hangs on my AM4 based Carrizo. What specific tests are you running when it hangs?</p> <p><br> </p> <p>Cheers,</p> <p>Tom</p> <br> <br> <div style="color: rgb(0, 0, 0);"> <div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Kuehling, Felix<br> <b>Sent:</b> Monday, August 8, 2016 13:57<br> <b>To:</b> amd-gfx@lists.freedesktop.org; StDenis, Tom<br> <b>Subject:</b> Re: [PATCH 09/14] drm/amd/amdgpu: Enable carrizo GFX PG</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">We're reverting this commit on the KFD branch because it's causing hangs<br> on a bunch of HSA compute tests on CZ.<br> <br> Regards,<br> Felix<br> <br> <br> On 16-07-28 10:19 AM, Tom St Denis wrote:<br> > Signed-off-by: Tom St Denis <tom.stdenis@amd.com><br> > ---<br> > drivers/gpu/drm/amd/amdgpu/vi.c | 6 ++++++<br> > 1 file changed, 6 insertions(+)<br> ><br> > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c<br> > index 9ba64989f092..4fa9fea541a5 100644<br> > --- a/drivers/gpu/drm/amd/amdgpu/vi.c<br> > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c<br> > @@ -1578,7 +1578,13 @@ static int vi_common_early_init(void *handle)<br> > AMD_CG_SUPPORT_HDP_LS |<br> > AMD_CG_SUPPORT_SDMA_MGCG |<br> > AMD_CG_SUPPORT_SDMA_LS;<br> > + /* rev0 hardware requires workarounds to support PG */<br> > adev->pg_flags = 0;<br> > + if (adev->rev_id != 0x00) {<br> > + adev->pg_flags |= AMD_PG_SUPPORT_GFX_PG |<br> > + AMD_PG_SUPPORT_GFX_SMG |<br> > + AMD_PG_SUPPORT_GFX_PIPELINE;<br> > + }<br> > adev->external_rev_id = adev->rev_id + 0x1;<br> > break;<br> > case CHIP_STONEY:<br> <br> </div> </span></font></div> </div> </body> </html>