<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;"> <p>Any modern GCC should support [0] at the tail of a struct. This came up because when I was reading the code I saw they allocated 7 slots (plus the size of the struct) but then fill 8 slots. It's just weird <img class="EmojiInsert" id="OWAEmoji502478" alt="😊" style="vertical-align: bottom;" src="cid:b9d342ca-4063-4b61-a23c-e54ecb4cfb09"></p> <p><br> </p> <p>Using [0] in the struct and allocating for 8 entries makes more sense and is clearer to read.</p> <p><br> </p> <p>Tom</p> <br> <br> <div style="color: rgb(0, 0, 0);"> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Christian König <deathsimple@vodafone.de><br> <b>Sent:</b> Thursday, August 18, 2016 11:17<br> <b>To:</b> StDenis, Tom; amd-gfx list<br> <b>Subject:</b> Re: tidy'ing up cz_hwmgr.c</font> <div> </div> </div> <div> <div class="moz-cite-prefix"> <blockquote type="cite"> <div>Has a [1] array at the tail which is then kzalloc'ed with N-1 entries. Shouldn't that just be a [0] with N entries allocated for clarity?</div> </blockquote> Actually the starting address of a dynamic array should be manually calculated instead of using [1] or [0].<br> <br> We had tons of problems with that because some gcc versions get this wrong and the atombios code used this as well.<br> <br> Alex how did we resolved such issues?<br> <br> Regards,<br> Christian.<br> <br> Am 18.08.2016 um 16:26 schrieb StDenis, Tom:<br> </div> <blockquote type="cite"> <div id="divtagdefaultwrapper" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif"> <p>Tidying up cz_hwmgr.c I noted a couple of things but first is </p> <p><br> </p> <div><span style="font-family:"Courier New",monospace">static bool cz_dpm_check_smu_features(struct pp_hwmgr *hwmgr,</span></div> <div><span class="Apple-tab-span" style="white-space:pre; font-family:"Courier New",monospace"></span><span style="font-family:"Courier New",monospace">unsigned long check_feature);</span></div> <div><br> </div> <div>Which will return "true" if the smu call fails <b>or</b> the feature is set. </div> <div><br> </div> <div>The structure </div> <div><br> </div> <div> <div><span style="font-family:"Courier New",monospace">struct phm_clock_voltage_dependency_table;</span></div> </div> <div><br> </div> <div>Has a [1] array at the tail which is then kzalloc'ed with N-1 entries. Shouldn't that just be a [0] with N entries allocated for clarity?</div> <div><br> </div> <div>Tom</div> <div><br> </div> </div> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <br> <pre>_______________________________________________ amd-gfx mailing list <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> </pre> </blockquote> <p><br> </p> </div> </div> </div> </body> </html>