<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;"> <p>Tidying up cz_hwmgr.c I noted a couple of things but first is </p> <p><br> </p> <p></p> <div><span style="font-family: "Courier New", monospace;">static bool cz_dpm_check_smu_features(struct pp_hwmgr *hwmgr,</span></div> <div><span class="Apple-tab-span" style="white-space: pre; font-family: "Courier New", monospace;"></span><span style="font-family: "Courier New", monospace;">unsigned long check_feature);</span></div> <div><br> </div> <div>Which will return "true" if the smu call fails <b>or</b> the feature is set. </div> <div><br> </div> <div>The structure </div> <div><br> </div> <div> <div><span style="font-family: "Courier New", monospace;">struct phm_clock_voltage_dependency_table;</span></div> </div> <div><br> </div> <div>Has a [1] array at the tail which is then kzalloc'ed with N-1 entries. Shouldn't that just be a [0] with N entries allocated for clarity?</div> <div><br> </div> <div>Tom</div> <div><br> </div> <p></p> </div> </body> </html>