<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;"> <p>Patch #3 is correct but missing the SDMA0 duplicate which I amended locally. I only noticed it after I hit send.</p> <br> <br> <div style="color: rgb(0, 0, 0);"> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Deucher, Alexander<br> <b>Sent:</b> Friday, August 26, 2016 12:49<br> <b>To:</b> StDenis, Tom; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> RE: [PATCH 3/3] drm/amd/powerplay: Only load MEC firmware once on Stoney</font> <div> </div> </div> <div> <div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:#1F497D">Wrong patch? ;)</span></p> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:#1F497D"> </span></p> <div style="border:none; border-left:solid blue 1.5pt; padding:0in 0in 0in 4.0pt"> <div> <div style="border:none; border-top:solid #B5C4DF 1.0pt; padding:3.0pt 0in 0in 0in"> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif""> amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] <b>On Behalf Of </b>StDenis, Tom<br> <b>Sent:</b> Friday, August 26, 2016 12:48 PM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH 3/3] drm/amd/powerplay: Only load MEC firmware once on Stoney</span></p> </div> </div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> </p> <div id="divtagdefaultwrapper"> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black">I swear this isn't intentional but I just realized that SDMA0 was loaded twice too only after hitting send-email. I've amended my patch locally to avoid loading SDMA0 twice too..</span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black">Tom</span></p> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <div> <div> <div align="center" style="text-align: center; margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <span style="font-family:"Calibri","sans-serif"; color:black"> <hr size="2" width="98%" align="center"> </span></div> <div id="x_divRplyFwdMsg"> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <b><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:black">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:black"> Tom St Denis <<a href="mailto:tstdenis82@gmail.com" style="color: blue; text-decoration: underline;">tstdenis82@gmail.com</a>><br> <b>Sent:</b> Friday, August 26, 2016 12:46<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org" style="color: blue; text-decoration: underline;"> amd-gfx@lists.freedesktop.org</a><br> <b>Cc:</b> StDenis, Tom<br> <b>Subject:</b> [PATCH 3/3] drm/amd/powerplay: Only load MEC firmware once on Stoney</span><span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> </div> </div> </div> <div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <span style="font-size:10.0pt; font-family:"Calibri","sans-serif"; color:black">Only load the MEC1 firmware once in the Carrizo SMU manager<br> driver.<br> <br> Signed-off-by: Tom St Denis <<a href="mailto:tom.stdenis@amd.com" style="color: blue; text-decoration: underline;">tom.stdenis@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 5 +----<br> 1 file changed, 1 insertion(+), 4 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c<br> index f51bd8de2f69..1529516089bc 100644<br> --- a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c<br> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c<br> @@ -574,10 +574,7 @@ static int cz_smu_construct_toc_for_bootup(struct pp_smumgr *smumgr)<br> CZ_SCRATCH_ENTRY_UCODE_ID_CP_ME, false);<br> cz_smu_populate_single_ucode_load_task(smumgr,<br> CZ_SCRATCH_ENTRY_UCODE_ID_CP_MEC_JT1, false);<br> - if (smumgr->chip_id == CHIP_STONEY)<br> - cz_smu_populate_single_ucode_load_task(smumgr,<br> - CZ_SCRATCH_ENTRY_UCODE_ID_CP_MEC_JT1, false);<br> - else<br> + if (smumgr->chip_id != CHIP_STONEY)<br> cz_smu_populate_single_ucode_load_task(smumgr,<br> CZ_SCRATCH_ENTRY_UCODE_ID_CP_MEC_JT2, false);<br> cz_smu_populate_single_ucode_load_task(smumgr,<br> -- <br> 2.9.3</span></p> </div> </div> </div> </div> </div> </div> </div> </div> </body> </html>