<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;"> <p>Yup, that looks better. My apologies. Guess that's the downside of having assertions for enable and disable in the same driver.</p> <p><br> </p> <p>Reviewed-by: Tom St Denis <tom.stdenis@amd.com></p> <br> <br> <div style="color: rgb(0, 0, 0);"> <div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Alex Deucher <alexdeucher@gmail.com><br> <b>Sent:</b> Wednesday, September 14, 2016 09:47<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Deucher, Alexander<br> <b>Subject:</b> [PATCH] drm/amdgpu/si/dpm: fix swapped ck enable</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">Fixes a regression in:<br> drm/amd/amdgpu: Tidy up SI SMC code<br> <br> bug:<br> <a href="https://bugs.freedesktop.org/show_bug.cgi?id=97801" id="LPlnk690514">https://bugs.freedesktop.org/show_bug.cgi?id=97801</a><br> <br> Signed-off-by: Alex Deucher <alexander.deucher@amd.com><br> ---<br> drivers/gpu/drm/amd/amdgpu/si_smc.c | 4 ++--<br> 1 file changed, 2 insertions(+), 2 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/si_smc.c b/drivers/gpu/drm/amd/amdgpu/si_smc.c<br> index 2cc628c..47bbb40 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/si_smc.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/si_smc.c<br> @@ -143,9 +143,9 @@ void si_smc_clock(struct amdgpu_device *adev, bool enable)<br> u32 tmp = RREG32_SMC(SMC_SYSCON_CLOCK_CNTL_0);<br> <br> if (enable)<br> - tmp |= CK_DISABLE;<br> - else<br> tmp &= ~CK_DISABLE;<br> + else<br> + tmp |= CK_DISABLE;<br> <br> WREG32_SMC(SMC_SYSCON_CLOCK_CNTL_0, tmp);<br> }<br> -- <br> 2.5.5<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> </div> </span></font></div> </div> </body> </html>