<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;"> <p>Looks correct and consistent with the other DCE drivers.</p> <p><br> </p> <p>Reviewed-by: Tom St Denis <tom.stdenis@amd.com></p> <br> <br> <div style="color: rgb(0, 0, 0);"> <div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Alex Deucher <alexdeucher@gmail.com><br> <b>Sent:</b> Monday, September 19, 2016 12:15<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Deucher, Alexander<br> <b>Subject:</b> [PATCH] drm/amdgpu/dce6: fix off by one in interrupt setup</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">Reported-by: Christian Inci <chris.pcguy.inci@gmail.com><br> Signed-off-by: Alex Deucher <alexander.deucher@amd.com><br> ---<br> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 4 ++--<br> 1 file changed, 2 insertions(+), 2 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c<br> index fb6dafd..c535f43 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c<br> @@ -185,7 +185,7 @@ static void dce_v6_0_pageflip_interrupt_init(struct amdgpu_device *adev)<br> unsigned i;<br> <br> /* Enable pflip interrupts */<br> - for (i = 0; i <= adev->mode_info.num_crtc; i++)<br> + for (i = 0; i < adev->mode_info.num_crtc; i++)<br> amdgpu_irq_get(adev, &adev->pageflip_irq, i);<br> }<br> <br> @@ -194,7 +194,7 @@ static void dce_v6_0_pageflip_interrupt_fini(struct amdgpu_device *adev)<br> unsigned i;<br> <br> /* Disable pflip interrupts */<br> - for (i = 0; i <= adev->mode_info.num_crtc; i++)<br> + for (i = 0; i < adev->mode_info.num_crtc; i++)<br> amdgpu_irq_put(adev, &adev->pageflip_irq, i);<br> }<br> <br> -- <br> 2.5.5<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk799182">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <div id="LPBorder_GT_14743019205100.9948496705656595" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;"> <table id="LPContainer_14743019205080.46813322174009464" cellspacing="0" style="width: 90%; background-color: rgb(255, 255, 255); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200);"> <tbody> <tr valign="top" style="border-spacing: 0px;"> <td id="TextCell_14743019205090.9650734273165438" colspan="2" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;"> <div id="LPRemovePreviewContainer_14743019205090.4944356703929571"></div> <div id="LPTitle_14743019205090.5298553736874863" style="top: 0px; color: rgb(59, 87, 119); font-weight: normal; font-size: 21px; font-family: wf_segoe-ui_light, "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;"> <a id="LPUrlAnchor_14743019205090.9067312658033573" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank" style="text-decoration: none;">amd-gfx Info Page - lists.freedesktop.org</a></div> <div id="LPMetadata_14743019205090.8173897951916467" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;"> lists.freedesktop.org</div> <div id="LPDescription_14743019205100.6752410840600065" style="display: block; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;"> To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...</div> </td> </tr> </tbody> </table> </div> <br> <br> </div> </span></font></div> </div> </body> </html>