<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <meta name="Generator" content="Microsoft Word 14 (filtered medium)"> <style></style> </head> <body bgcolor="white" lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> Wait, nevermind. It would be good to add a comment that addr needs to be reset to 0 in this case since it's used below in the amdgpu_vm_frag_ptes().<o:p></o:p> <o:p> </o:p> The patch is:<o:p></o:p> Reviewed-by: Alex Deucher <alexander.deucher@amd.com><o:p></o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf Of Deucher, Alexander Sent: Monday, September 26, 2016 11:17 AM To: 'Christian König'; StDenis, Tom; Cui, Flora Cc: Huang, Ray; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: fix addr handling in amdgpu_vm_bo_update_mapping<o:p></o:p> </div> </div> <o:p> </o:p> Maybe it would be cleaner to just pass 0 to amdgpu_vm_frag_ptes() or remove the parameter altogether.<o:p></o:p> <o:p></o:p> Alex<o:p></o:p> <o:p></o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> From: amd-gfx [<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">mailto:amd-gfx-bounces@lists.freedesktop.org</a>] On Behalf Of Christian König Sent: Monday, September 26, 2016 11:12 AM To: StDenis, Tom; Cui, Flora Cc: Huang, Ray; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> Subject: Re: [PATCH] drm/amdgpu: fix addr handling in amdgpu_vm_bo_update_mapping<o:p></o:p> </div> </div> <o:p></o:p> <div> The function called is either amdgpu_vm_do_set_ptes() or amdgpu_vm_do_copy_ptes(). But that is actually rather unrelated to the local handling of addr in the function changed. The point here is we have handled the address offset by giving it to amdgpu_vm_map_gart() and so we shouldn't add the address again. Regards, Christian. Am 26.09.2016 um 15:46 schrieb StDenis, Tom:<o:p></o:p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div id="divtagdefaultwrapper"> I'm reading through the amdgpu_vm.c to try and see if the patch is correct but I'm not that familiar with the VM side of things. It seems to boil down to calling params->func() with a new dst value of NULL but that's where I'm stopped at the moment since I don't know what func() is. Nothing up to that point looks overtly wrong (like trying to use that address as a source for a read/write).<o:p></o:p> <o:p></o:p> Tom<o:p></o:p> <o:p></o:p> <div> <div> <div class="MsoNormal" align="center" style="text-align:center;background:white"> <hr size="2" width="98%" align="center"> </div> <div id="x_divRplyFwdMsg"> From: amd-gfx <a href="mailto:amd-gfx-bounces@lists.freedesktop.org"><amd-gfx-bounces@lists.freedesktop.org></a> on behalf of Christian König <a href="mailto:deathsimple@vodafone.de"><deathsimple@vodafone.de></a> Sent: Monday, September 26, 2016 09:29 To: Cui, Flora Cc: Huang, Ray; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> Subject: Re: [PATCH] drm/amdgpu: fix addr handling in amdgpu_vm_bo_update_mapping <o:p></o:p> <div> <o:p></o:p> </div> </div> </div> <div> Yeah, that wouldn't really help but just make the problem more unlikely to happen once more. Anyway Tom St confirmed that the patch seems to work for the open stack. Anybody brave enough to throw an rb on this so that I can commit it? Thanks, Christian. Am 26.09.2016 um 11:16 schrieb Flora Cui: > please ignore this patch. it actually revert the gtt mgr changes. > > On Mon, Sep 26, 2016 at 03:19:01PM +0800, Flora Cui wrote: >> On Sun, Sep 25, 2016 at 11:55:13AM +0200, Christian König wrote: >>> From: Christian König <a href="mailto:christian.koenig@amd.com"><christian.koenig@amd.com></a> >>> >>> Otherwise we will look at the wrong place in the IB when GART >>> mappings are split into smaller updates. >>> >>> Signed-off-by: Christian König <a href="mailto:christian.koenig@amd.com"><christian.koenig@amd.com></a> >>> --- >>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c >>> index 2bb78dc..da31189 100644 >>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c >>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c >>> @@ -1017,6 +1017,7 @@ static int amdgpu_vm_bo_update_mapping(struct amdgpu_device *adev, >>> AMDGPU_GPU_PAGE_SIZE); >>> pte[i] |= flags; >>> } >>> + addr = 0; >>> } >>> >>> r = amdgpu_sync_fence(adev, &job->sync, exclusive); >>> -- >>> 2.5.0 >>> >>> >> IMHO this could fix the vmfault issue. >> >> 8<--- >> From cc7b5618665defd88e2adcd6f735562ecd784298 Mon Sep 17 00:00:00 2001 >> From: Flora Cui <a href="mailto:Flora.Cui@amd.com"><Flora.Cui@amd.com></a> >> Date: Mon, 26 Sep 2016 15:14:02 +0800 >> Subject: [PATCH] drm/amdgpu: add ttm_bind in amdgpu_vm_bo_update() >> >> Change-Id: If73d5b06e9188e40250ccdfd1a2a659ed1ef52a6 >> Signed-off-by: Flora Cui <a href="mailto:Flora.Cui@amd.com"><Flora.Cui@amd.com></a> >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c >> index 2bb78dc..7f17127 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c >> @@ -1166,6 +1166,8 @@ int amdgpu_vm_bo_update(struct amdgpu_device *adev, >> ttm = container_of(bo_va->bo->tbo.ttm, struct >> ttm_dma_tt, ttm); >> pages_addr = ttm->dma_address; >> + amdgpu_ttm_bind(&bo_va->bo->tbo, mem); >> + addr = (u64)mem->start << PAGE_SHIFT; >> break; >> >> case TTM_PL_VRAM: >> -- >> 2.7.4 >> >> >> _______________________________________________ >> amd-gfx mailing list >> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> >> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk752113"> https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <o:p></o:p> <div style="margin-bottom:15.0pt;overflow:auto" id="LPBorder_GT_14748974921180.061148974248180776"> <table class="MsoNormalTable" border="1" cellspacing="0" cellpadding="0" width="90%" style="width:90.0%;border-top:dotted #C8C8C8 1.0pt;border-left:none;border-bottom:dotted #C8C8C8 1.0pt;border-right:none"> <tbody> <tr> <td valign="top" style="border:none;padding:0in 0in 0in 0in"> <div id="LPTitle_14748974921170.667584414663523"> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank">amd-gfx Info Page - lists.freedesktop.org</a><o:p></o:p> </div> <div style="margin-top:7.5pt;margin-bottom:12.0pt" id="LPMetadata_14748974921170.8198680036506909"> lists.freedesktop.org<o:p></o:p> </div> <div id="LPDescription_14748974921180.08916125964466382"> To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...<o:p></o:p> </div> </td> </tr> </tbody> </table> </div> > _______________________________________________ > amd-gfx mailing list > <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> > <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> _______________________________________________ amd-gfx mailing list <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><o:p></o:p> </div> </div> </div> </blockquote> <o:p></o:p> </div> </div> </div> </body> </html>