<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;"> <p>Better would be to add them to a bitmask header and then use REG_GET_FIELD() so it's nice and clean looking.</p> <p><br> </p> <p>Tom</p> <br> <br> <div style="color: rgb(0, 0, 0);"> <div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Christian König <deathsimple@vodafone.de><br> <b>Sent:</b> Tuesday, September 27, 2016 08:52<br> <b>To:</b> Edward O'Callaghan; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH 2/2] drm/amdkfd: Decode bit fields in 'cik_ih_ring_entry' directly</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">NAK, don't use bitfields to decode hardware values. They aren't portable.<br> <br> Regards,<br> Christian.<br> <br> Am 27.09.2016 um 14:47 schrieb Edward O'Callaghan:<br> > Signed-off-by: Edward O'Callaghan <funfunctor@folklore1984.net><br> > ---<br> > drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 15 +++++----------<br> > drivers/gpu/drm/amd/amdkfd/cik_int.h | 20 ++++++++++++++++----<br> > 2 files changed, 21 insertions(+), 14 deletions(-)<br> ><br> > diff --git a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c<br> > index 211fc48..1c47b9e 100644<br> > --- a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c<br> > +++ b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c<br> > @@ -27,14 +27,12 @@<br> > static bool cik_event_interrupt_isr(struct kfd_dev *dev,<br> > const uint32_t *ih_ring_entry)<br> > {<br> > - unsigned int pasid;<br> > const struct cik_ih_ring_entry *ihre =<br> > (const struct cik_ih_ring_entry *)ih_ring_entry;<br> > <br> > - pasid = (ihre->ring_id & 0xffff0000) >> 16;<br> > <br> > /* Do not process in ISR, just request it to be forwarded to WQ. */<br> > - return (pasid != 0) &&<br> > + return (ihre->pasid != 0) &&<br> > (ihre->source_id == CIK_INTSRC_CP_END_OF_PIPE ||<br> > ihre->source_id == CIK_INTSRC_SQ_INTERRUPT_MSG ||<br> > ihre->source_id == CIK_INTSRC_CP_BAD_OPCODE);<br> > @@ -43,21 +41,18 @@ static bool cik_event_interrupt_isr(struct kfd_dev *dev,<br> > static void cik_event_interrupt_wq(struct kfd_dev *dev,<br> > const uint32_t *ih_ring_entry)<br> > {<br> > - unsigned int pasid;<br> > const struct cik_ih_ring_entry *ihre =<br> > (const struct cik_ih_ring_entry *)ih_ring_entry;<br> > <br> > - pasid = (ihre->ring_id & 0xffff0000) >> 16;<br> > -<br> > - if (pasid == 0)<br> > + if (ihre->pasid == 0)<br> > return;<br> > <br> > if (ihre->source_id == CIK_INTSRC_CP_END_OF_PIPE)<br> > - kfd_signal_event_interrupt(pasid, 0, 0);<br> > + kfd_signal_event_interrupt(ihre->pasid, 0, 0);<br> > else if (ihre->source_id == CIK_INTSRC_SQ_INTERRUPT_MSG)<br> > - kfd_signal_event_interrupt(pasid, ihre->data & 0xFF, 8);<br> > + kfd_signal_event_interrupt(ihre->pasid, ihre->data & 0xFF, 8);<br> > else if (ihre->source_id == CIK_INTSRC_CP_BAD_OPCODE)<br> > - kfd_signal_hw_exception_event(pasid);<br> > + kfd_signal_hw_exception_event(ihre->pasid);<br> > }<br> > <br> > const struct kfd_event_interrupt_class event_interrupt_class_cik = {<br> > diff --git a/drivers/gpu/drm/amd/amdkfd/cik_int.h b/drivers/gpu/drm/amd/amdkfd/cik_int.h<br> > index 79a16d2..27d1ede 100644<br> > --- a/drivers/gpu/drm/amd/amdkfd/cik_int.h<br> > +++ b/drivers/gpu/drm/amd/amdkfd/cik_int.h<br> > @@ -26,10 +26,22 @@<br> > #include <linux/types.h><br> > <br> > struct cik_ih_ring_entry {<br> > - uint32_t source_id;<br> > - uint32_t data;<br> > - uint32_t ring_id;<br> > - uint32_t reserved;<br> > + uint32_t source_id:8;<br> > + uint32_t reserved1:8;<br> > + uint32_t reserved2:16;<br> > +<br> > + uint32_t data:28;<br> > + uint32_t reserved3:4;<br> > +<br> > + /* pipeid, meid and unused3 are officially called RINGID,<br> > + * but for our purposes, they always decode into pipe and ME. */<br> > + uint32_t pipeid:2;<br> > + uint32_t meid:2;<br> > + uint32_t reserved4:4;<br> > + uint32_t vmid:8;<br> > + uint32_t pasid:16;<br> > +<br> > + uint32_t reserved5;<br> > };<br> > <br> > #define CIK_INTSRC_DEQUEUE_COMPLETE 0xC6<br> <br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk334039" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <div id="LPBorder_GT_14749812728050.7048501784478629" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;"> <table id="LPContainer_14749812728030.5642919220195035" cellspacing="0" style="width: 90%; background-color: rgb(255, 255, 255); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200);"> <tbody> <tr valign="top" style="border-spacing: 0px;"> <td id="TextCell_14749812728040.9268417870047556" colspan="2" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;"> <div id="LPRemovePreviewContainer_14749812728040.34307252866659876"></div> <div id="LPTitle_14749812728040.8388090385131661" style="top: 0px; color: rgb(59, 87, 119); font-weight: normal; font-size: 21px; font-family: wf_segoe-ui_light, "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;"> <a id="LPUrlAnchor_14749812728050.28844807438263875" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank" style="text-decoration: none;">amd-gfx Info Page - lists.freedesktop.org</a></div> <div id="LPMetadata_14749812728050.9572512473940396" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;"> lists.freedesktop.org</div> <div id="LPDescription_14749812728050.8362385945355966" style="display: block; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;"> To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...</div> </td> </tr> </tbody> </table> </div> <br> <br> </div> </span></font></div> </div> </body> </html>