<div dir="ltr">I proposed to remove that when running into SDMA job out-of-order issues and Christian K very strongly NAK'ed that (a couple of times).<div><br></div><div>So I suspect he'll do it again.</div><div><br></div><div>Tom</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Oct 5, 2016 at 8:10 PM Dave Airlie <<a href="mailto:airlied@gmail.com">airlied@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 6 October 2016 at 05:42, Alex Deucher <<a href="mailto:alexdeucher@gmail.com" class="gmail_msg" target="_blank">alexdeucher@gmail.com</a>> wrote:<br class="gmail_msg">
> Looks like fallout from a rebase or merge.<br class="gmail_msg">
<br class="gmail_msg">
Nearly sure we do it twice on purpose, at least radeon does it as well.<br class="gmail_msg">
<br class="gmail_msg">
so NAK without a better explaination.<br class="gmail_msg">
<br class="gmail_msg">
Dave.<br class="gmail_msg">
<br class="gmail_msg">
><br class="gmail_msg">
> Signed-off-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com" class="gmail_msg" target="_blank">alexander.deucher@amd.com</a>><br class="gmail_msg">
> ---<br class="gmail_msg">
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---<br class="gmail_msg">
>  1 file changed, 3 deletions(-)<br class="gmail_msg">
><br class="gmail_msg">
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br class="gmail_msg">
> index 45259b5..c2f70be 100644<br class="gmail_msg">
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br class="gmail_msg">
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br class="gmail_msg">
> @@ -1956,9 +1956,6 @@ int amdgpu_device_suspend(struct drm_device *dev, bool suspend, bool fbcon)<br class="gmail_msg">
><br class="gmail_msg">
>         r = amdgpu_suspend(adev);<br class="gmail_msg">
><br class="gmail_msg">
> -       /* evict remaining vram memory */<br class="gmail_msg">
> -       amdgpu_bo_evict_vram(adev);<br class="gmail_msg">
> -<br class="gmail_msg">
>         pci_save_state(dev->pdev);<br class="gmail_msg">
>         if (suspend) {<br class="gmail_msg">
>                 /* Shut down the device */<br class="gmail_msg">
> --<br class="gmail_msg">
> 2.5.5<br class="gmail_msg">
><br class="gmail_msg">
> _______________________________________________<br class="gmail_msg">
> amd-gfx mailing list<br class="gmail_msg">
> <a href="mailto:amd-gfx@lists.freedesktop.org" class="gmail_msg" target="_blank">amd-gfx@lists.freedesktop.org</a><br class="gmail_msg">
> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
amd-gfx mailing list<br class="gmail_msg">
<a href="mailto:amd-gfx@lists.freedesktop.org" class="gmail_msg" target="_blank">amd-gfx@lists.freedesktop.org</a><br class="gmail_msg">
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br class="gmail_msg">
</blockquote></div>