<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">
<blockquote type="cite">i'm a trailblazer of bad ideas at times
:-) hehehehe</blockquote>
Well, I know this because I had the same bad idea earlier and
spend a lot of time bisecting why it broke :)<br>
<br>
Christian.<br>
<br>
Am 09.10.2016 um 19:54 schrieb Tom St Denis:<br>
</div>
<blockquote
cite="mid:CAAzXoRKnei7U3hvUCosvpOB8z9kM6CL1Lg5GduyzfUpW9ZrxKQ@mail.gmail.com"
type="cite">
<div dir="ltr">Yup that's what I said in another part of the
thread :-)
<div><br>
</div>
<div>i'm a trailblazer of bad ideas at times :-) hehehehe</div>
<div><br>
</div>
<div>Tom</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Sun, Oct 9, 2016 at 11:13 AM Christian König
<<a moz-do-not-send="true"
href="mailto:deathsimple@vodafone.de">deathsimple@vodafone.de</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Am
05.10.2016 um 21:42 schrieb Alex Deucher:<br class="gmail_msg">
> Looks like fallout from a rebase or merge.<br
class="gmail_msg">
><br class="gmail_msg">
> Signed-off-by: Alex Deucher <<a moz-do-not-send="true"
href="mailto:alexander.deucher@amd.com" class="gmail_msg"
target="_blank">alexander.deucher@amd.com</a>><br
class="gmail_msg">
<br class="gmail_msg">
NAK, this is done on purpose and is for evicting the GART
table using<br class="gmail_msg">
memcpy.<br class="gmail_msg">
<br class="gmail_msg">
Tom wanted to remove that as well and it makes resume then
fail horrible<br class="gmail_msg">
on dGPUs.<br class="gmail_msg">
<br class="gmail_msg">
We should probably add a comment why this is necessary.<br
class="gmail_msg">
<br class="gmail_msg">
Christian.<br class="gmail_msg">
<br class="gmail_msg">
> ---<br class="gmail_msg">
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---<br
class="gmail_msg">
> 1 file changed, 3 deletions(-)<br class="gmail_msg">
><br class="gmail_msg">
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br
class="gmail_msg">
> index 45259b5..c2f70be 100644<br class="gmail_msg">
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br
class="gmail_msg">
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br
class="gmail_msg">
> @@ -1956,9 +1956,6 @@ int amdgpu_device_suspend(struct
drm_device *dev, bool suspend, bool fbcon)<br
class="gmail_msg">
><br class="gmail_msg">
> r = amdgpu_suspend(adev);<br class="gmail_msg">
><br class="gmail_msg">
> - /* evict remaining vram memory */<br
class="gmail_msg">
> - amdgpu_bo_evict_vram(adev);<br class="gmail_msg">
> -<br class="gmail_msg">
> pci_save_state(dev->pdev);<br class="gmail_msg">
> if (suspend) {<br class="gmail_msg">
> /* Shut down the device */<br
class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br
class="gmail_msg">
amd-gfx mailing list<br class="gmail_msg">
<a moz-do-not-send="true"
href="mailto:amd-gfx@lists.freedesktop.org"
class="gmail_msg" target="_blank">amd-gfx@lists.freedesktop.org</a><br
class="gmail_msg">
<a moz-do-not-send="true"
href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx"
rel="noreferrer" class="gmail_msg" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br
class="gmail_msg">
</blockquote>
</div>
</blockquote>
<p><br>
</p>
</body>
</html>