<div dir="ltr">Means the drm pull request for 4.9 is broken then also, FYI.<br></div><div class="gmail_extra"><br><div class="gmail_quote">2016-10-14 15:17 GMT+02:00 Ernst Sjöstrand <span dir="ltr"><<a href="mailto:ernstp@gmail.com" target="_blank">ernstp@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>9d24b304abbe5380da1bc782b44605<wbr>96e7cb1109<br></div>cherry-picks cleanly on drm-next-4.9-wip but then fails to build:<br><br> CC [M] drivers/gpu/drm/amd/amdgpu/<wbr>vce_v3_0.o<br>drivers/gpu/drm/amd/amdgpu/<wbr>vce_v3_0.c:854:2: error: unknown field ‘type’ specified in initializer<br> .type = AMDGPU_RING_TYPE_VCE,<br> ^<br>drivers/gpu/drm/amd/amdgpu/<wbr>vce_v3_0.c:854:10: warning: initialization makes pointer from integer without a cast [-Wint-conversion]<br> .type = AMDGPU_RING_TYPE_VCE,<br> ^<br>drivers/gpu/drm/amd/amdgpu/<wbr>vce_v3_0.c:854:10: note: (near initialization for ‘vce_v3_0_ring_phys_funcs.get_<wbr>rptr’)<br>drivers/gpu/drm/amd/amdgpu/<wbr>vce_v3_0.c:855:2: error: unknown field ‘align_mask’ specified in initializer<br> .align_mask = 0xf,<br> ^<br>drivers/gpu/drm/amd/amdgpu/<wbr>vce_v3_0.c:855:16: warning: initialization makes pointer from integer without a cast [-Wint-conversion]<br> .align_mask = 0xf,<br> ^<br>drivers/gpu/drm/amd/amdgpu/<wbr>vce_v3_0.c:855:16: note: (near initialization for ‘vce_v3_0_ring_phys_funcs.get_<wbr>wptr’)<br>drivers/gpu/drm/amd/amdgpu/<wbr>vce_v3_0.c:856:2: error: unknown field ‘nop’ specified in initializer<br> .nop = VCE_CMD_NO_OP,<br> ^<br><br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">2016-10-14 15:15 GMT+02:00 Ernst Sjöstrand <span dir="ltr"><<a href="mailto:ernstp@gmail.com" target="_blank">ernstp@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><div><div><div>I'm testing both drm-next-4.9 and drm-next-4.9-wip from ~agd5f.<br></div>I think the problem is in drm-next now also.<br></div>They all have<br>6f0359f drm/amdgpu/vce3: add support for third vce ring<br>75c6548 drm/amdgpu: track the number of vce rings<br><br></div>But not<br>9d24b30 drm/amdgpu: fix broken VCE startup in phys mode<br></div>which only exists in amd-staging-4.7<br></div>(What does 4.7 mean in this context... ?)<br><br></div>Regards<span class="m_-2167022505463390063HOEnZb"><font color="#888888"><br></font></span></div><span class="m_-2167022505463390063HOEnZb"><font color="#888888">//Ernst<br><div><div><div><br></div></div></div></font></span></div><div class="m_-2167022505463390063HOEnZb"><div class="m_-2167022505463390063h5"><div class="gmail_extra"><br><div class="gmail_quote">2016-10-14 15:07 GMT+02:00 StDenis, Tom <span dir="ltr"><<a href="mailto:Tom.StDenis@amd.com" target="_blank">Tom.StDenis@amd.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div dir="ltr"> <div id="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif"> <p>Do you have <a href="https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.7-wip&id=9d24b304abbe5380da1bc782b4460596e7cb1109" class="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421OWAAutoLink" id="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421LPlnk640528" target="_blank">https://cgit.freedesktop.<wbr>org/~agd5f/linux/commit/?h=drm<wbr>-next-4.7-wip&id=9d24b304abbe5<wbr>380da1bc782b4460596e7cb1109</a> as well?</p> <p><br> </p> <p>I've booted the tip of our staging-4.7 branch with a FIJI device (FURY) and was able to play videos (vdpau) and normal GL apps.</p> <p><br> </p> <p>Tom</p> <br> <br> <div style="color:rgb(0,0,0)"> <hr style="display:inline-block;width:98%"> <div id="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" color="#000000" face="Calibri, sans-serif"><b>From:</b> Ernst Sjöstrand <<a href="mailto:ernstp@gmail.com" target="_blank">ernstp@gmail.com</a>><br> <b>Sent:</b> Friday, October 14, 2016 09:05<br> <b>To:</b> StDenis, Tom<br> <b>Cc:</b> <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br> <b>Subject:</b> Re: [PATCH] amdgpu: Fix failing boot after support for third vce ring</font> <div> </div> </div><div><div class="m_-2167022505463390063m_7545045248063895902h5"> <div> <div dir="ltr"> <div>Yes, the 6f0359ff73076483902de0c17f9649<wbr>bf55651e2a I'm referring to is the same as <br> <span><span>780605db12c52f2c22d4d2cc05ceb7<wbr>d2a9d55579 (only exists in amd-staging).<br> </span></span></div> <span><span>So the last of those two commits is the one that causes my problem.<br> </span></span> <div><span><span><br> </span></span></div> <div><span><span>Regards<br> </span></span></div> <div><span><span>//Ernst<br> </span></span></div> </div> <div class="gmail_extra"><br> <div class="gmail_quote">2016-10-14 14:53 GMT+02:00 StDenis, Tom <span dir="ltr"> <<a href="mailto:Tom.StDenis@amd.com" target="_blank">Tom.StDenis@amd.com</a>></span>:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div dir="ltr"> <div id="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif"> <p>Does your tree have </p> <p><br> </p> <p><span>2f3d686d0ee95332d8888169c7b678<wbr>8bb2d9f5ad</span><br> </p> <p><span><span>780605db12c52f2c22d4d2cc05ceb7<wbr>d2a9d55579</span><br> </span></p> <p><span><span><br> </span></span></p> <p><span><span>in it? Those are fixes for when the third ring were added.</span></span></p> <p><span><span><br> </span></span></p> <p><span><span>Tom</span></span></p> <br> <br> <div style="color:rgb(0,0,0)"> <div> <hr style="display:inline-block;width:98%"> <div id="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824x_divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" color="#000000" face="Calibri, sans-serif"><b>From:</b> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org" target="_blank">amd-gfx-bounces@lists.freedes<wbr>ktop.org</a>> on behalf of Ernst Sjöstrand <<a href="mailto:ernstp@gmail.com" target="_blank">ernstp@gmail.com</a>><br> <b>Sent:</b> Friday, October 14, 2016 08:49<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br> <b>Cc:</b> Ernst Sjöstrand<br> <b>Subject:</b> [PATCH] amdgpu: Fix failing boot after support for third vce ring</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt"> <div class="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824PlainText"> <div> <div class="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421h5">My Fiji class Fury fails to boot after commit<br> 6f0359ff73076483902de0c17f9649<wbr>bf55651e2a<br> "drm/amdgpu/vce3: add support for third vce ring"<br> This commits reverts the number of vce rings back to 2,<br> but leaves the other changes intact.<br> <br> Signed-off-by: Ernst Sjöstrand <<a href="mailto:ernstp@gmail.com" target="_blank">ernstp@gmail.com</a>><br> ---<br> drivers/gpu/drm/amd/amdgpu/vc<wbr>e_v3_0.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/v<wbr>ce_v3_0.c b/drivers/gpu/drm/amd/amdgpu/v<wbr>ce_v3_0.c<br> index 3f899e3..6f5eb64 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/v<wbr>ce_v3_0.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/v<wbr>ce_v3_0.c<br> @@ -358,7 +358,7 @@ static int vce_v3_0_early_init(void *handle)<br> (AMDGPU_VCE_HARVEST_VCE0 | AMDGPU_VCE_HARVEST_VCE1))<br> return -ENOENT;<br> <br> - adev->vce.num_rings = 3;<br> + adev->vce.num_rings = 2;<br> <br> vce_v3_0_set_ring_funcs(adev);<br> vce_v3_0_set_irq_funcs(adev);<br> -- <br> 2.7.4<br> <br> </div> </div> ______________________________<wbr>_________________<br> amd-gfx mailing list<br> <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824LPlnk959250" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/amd-gfx</a> <div id="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824LPBorder_GT_14764495470470.9881266530783932" style="margin-bottom:20px;overflow:auto;width:100%;text-indent:0px"> <table id="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824LPContainer_14764495470450.11026149163994892" style="width:90%;background-color:rgb(255,255,255);overflow:auto;padding-top:20px;padding-bottom:20px;margin-top:20px;border-top:1px dotted rgb(200,200,200);border-bottom:1px dotted rgb(200,200,200)" cellspacing="0"> <tbody> <tr style="border-spacing:0px" valign="top"> <td id="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824TextCell_14764495470460.7288026297683508" colspan="2" style="vertical-align:top;padding:0px;display:table-cell"> <div id="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824LPRemovePreviewContainer_14764495470460.16427690046159027"> </div> <div id="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824LPTitle_14764495470460.741636132433581" style="color:rgb(59,87,119);font-weight:normal;font-size:21px;font-family:wf_segoe-ui_light,"Segoe UI Light","Segoe WP Light","Segoe UI","Segoe WP",Tahoma,Arial,sans-serif;line-height:21px"> <a id="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824LPUrlAnchor_14764495470460.2698087919077241" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" style="text-decoration:none" target="_blank">amd-gfx Info Page - lists.freedesktop.org</a></div> <div id="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824LPMetadata_14764495470460.18698958466014992" style="margin:10px 0px 16px;color:rgb(102,102,102);font-weight:normal;font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif;font-size:14px;line-height:14px"> <a href="http://lists.freedesktop.org" target="_blank">lists.freedesktop.org</a></div> <div id="m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824LPDescription_14764495470460.6448197846508978" style="display:block;color:rgb(102,102,102);font-weight:normal;font-family:wf_segoe-ui_normal,"Segoe UI","Segoe WP",Tahoma,Arial,sans-serif;font-size:14px;line-height:20px;max-height:100px;overflow:hidden"> To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...</div> </td> </tr> </tbody> </table> </div> <br> <br> </div> </span></font></div> </div> </div> </blockquote> </div> <br> </div> </div> </div></div></div> </div> </div> </blockquote></div><br></div> </div></div></blockquote></div><br></div> </div></div></blockquote></div><br></div>