<div dir="ltr"><a href="https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.7-wip&id=9d24b304abbe5380da1bc782b4460596e7cb1109">https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.7-wip&id=9d24b304abbe5380da1bc782b4460596e7cb1109</a> </div><div class="gmail_extra"> <div class="gmail_quote">2016-10-14 16:12 GMT+02:00 Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com" target="_blank">Alexander.Deucher@amd.com</a>>: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div link="blue" vlink="purple" lang="EN-US"> <div class="m_5585073502184114943WordSection1"> What patch are you referring to? Alex <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in"> From: Ernst Sjöstrand [mailto:<a href="mailto:ernstp@gmail.com" target="_blank">ernstp@gmail.com</a>] Sent: Friday, October 14, 2016 10:06 AM To: Deucher, Alexander Cc: amd-gfx mailing list; StDenis, Tom Subject: RE: [PATCH] amdgpu: Fix failing boot after support for third vce ring </div> </div><div><div class="h5"> next-4.9 and wip are the broken branches for me so something is wrong. I could cherry pick the patch Tom mentioned and got a delta so I don't think you have it. <div> <div> Den 14 okt. 2016 3:49 em skrev "Deucher, Alexander" <<a href="mailto:Alexander.Deucher@amd.com" target="_blank">Alexander.Deucher@amd.com</a>>: <div> <div> All of those patches are integrated: <a href="https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.9-wip&id=57da26e4c4c1c7cc042aba1925813fea7413dbeb" target="_blank">https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.9-wip&id=57da26e4c4c1c7cc042aba1925813fea7413dbeb</a> <a href="https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.9-wip&id=d7ca7ab8259f43473bc387dda2a5b84aeb049961" target="_blank">https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.9-wip&id=d7ca7ab8259f43473bc387dda2a5b84aeb049961</a> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in"> From: amd-gfx [mailto:<a href="mailto:amd-gfx-bounces@lists.freedesktop.org" target="_blank">amd-gfx-bounces@lists.freedesktop.org</a>] On Behalf Of StDenis, Tom Sent: Friday, October 14, 2016 9:21 AM To: Ernst Sjöstrand Cc: <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a> Subject: Re: [PATCH] amdgpu: Fix failing boot after support for third vce ring </div> </div> <div id="m_5585073502184114943m_2020318726477089758m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824LPMetadata_14764495470460.18698958466014992"> You'd need <a href="https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.7-wip&id=9ab4662c313d25731e53cc4f044bddb9c506ca13" id="m_5585073502184114943m_2020318726477089758LPlnk511980" target="_blank">https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.7-wip&id=9ab4662c313d25731e53cc4f044bddb9c506ca13</a> and <a href="https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.7-wip&id=da00756f75422b04befae381e7e48d0cacf299f3" id="m_5585073502184114943m_2020318726477089758LPlnk276724" target="_blank">https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.7-wip&id=da00756f75422b04befae381e7e48d0cacf299f3</a> I'll let Alex speak for the drm-next branches since he manages them. Tom <div> <div class="MsoNormal" style="text-align:center" align="center"> <hr width="98%" size="2" align="center"> </div> <div id="m_5585073502184114943m_2020318726477089758divRplyFwdMsg"> From: Ernst Sjöstrand <<a href="mailto:ernstp@gmail.com" target="_blank">ernstp@gmail.com</a>> Sent: Friday, October 14, 2016 09:20 To: StDenis, Tom Cc: <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a> Subject: Re: [PATCH] amdgpu: Fix failing boot after support for third vce ring <div> </div> </div> <div> <div> Means the drm pull request for 4.9 is broken then also, FYI. </div> <div> <div> 2016-10-14 15:17 GMT+02:00 Ernst Sjöstrand <<a href="mailto:ernstp@gmail.com" target="_blank">ernstp@gmail.com</a>>: <div> <div> 9d24b304abbe5380da1bc782b4460596e7cb1109 </div> cherry-picks cleanly on drm-next-4.9-wip but then fails to build: CC [M] drivers/gpu/drm/amd/amdgpu/vce_v3_0.o drivers/gpu/drm/amd/amdgpu/vce_v3_0.c:854:2: error: unknown field ‘type’ specified in initializer .type = AMDGPU_RING_TYPE_VCE, ^ drivers/gpu/drm/amd/amdgpu/vce_v3_0.c:854:10: warning: initialization makes pointer from integer without a cast [-Wint-conversion] .type = AMDGPU_RING_TYPE_VCE, ^ drivers/gpu/drm/amd/amdgpu/vce_v3_0.c:854:10: note: (near initialization for ‘vce_v3_0_ring_phys_funcs.get_rptr’) drivers/gpu/drm/amd/amdgpu/vce_v3_0.c:855:2: error: unknown field ‘align_mask’ specified in initializer .align_mask = 0xf, ^ drivers/gpu/drm/amd/amdgpu/vce_v3_0.c:855:16: warning: initialization makes pointer from integer without a cast [-Wint-conversion] .align_mask = 0xf, ^ drivers/gpu/drm/amd/amdgpu/vce_v3_0.c:855:16: note: (near initialization for ‘vce_v3_0_ring_phys_funcs.get_wptr’) drivers/gpu/drm/amd/amdgpu/vce_v3_0.c:856:2: error: unknown field ‘nop’ specified in initializer .nop = VCE_CMD_NO_OP, ^ </div> <div> <div> <div> <div> 2016-10-14 15:15 GMT+02:00 Ernst Sjöstrand <<a href="mailto:ernstp@gmail.com" target="_blank">ernstp@gmail.com</a>>: <div> <div> <div> <div> <div> <div> <div> <div> I'm testing both drm-next-4.9 and drm-next-4.9-wip from ~agd5f. </div> I think the problem is in drm-next now also. </div> They all have 6f0359f drm/amdgpu/vce3: add support for third vce ring 75c6548 drm/amdgpu: track the number of vce rings </div> But not 9d24b30 drm/amdgpu: fix broken VCE startup in phys mode </div> which only exists in amd-staging-4.7 </div> (What does 4.7 mean in this context... ?) </div> Regards </div> //Ernst <div> <div> <div> </div> </div> </div> </div> <div> <div> <div> <div> 2016-10-14 15:07 GMT+02:00 StDenis, Tom <<a href="mailto:Tom.StDenis@amd.com" target="_blank">Tom.StDenis@amd.com</a>>: <div> <div> Do you have <a href="https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.7-wip&id=9d24b304abbe5380da1bc782b4460596e7cb1109" id="m_5585073502184114943m_2020318726477089758m_-2167022505463390063m_7545045248063895902m_-8133334703298494421LPlnk640528" target="_blank">https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.7-wip&id=9d24b304abbe5380da1bc782b4460596e7cb1109</a> as well? I've booted the tip of our staging-4.7 branch with a FIJI device (FURY) and was able to play videos (vdpau) and normal GL apps. Tom <div> <div class="MsoNormal" style="text-align:center" align="center"> <hr width="98%" size="2" align="center"> </div> <div id="m_5585073502184114943m_2020318726477089758m_-2167022505463390063m_7545045248063895902m_-8133334703298494421divRplyFwdMsg"> From: Ernst Sjöstrand <<a href="mailto:ernstp@gmail.com" target="_blank">ernstp@gmail.com</a>> Sent: Friday, October 14, 2016 09:05 To: StDenis, Tom Cc: <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a> Subject: Re: [PATCH] amdgpu: Fix failing boot after support for third vce ring <div> </div> </div> <div> <div> <div> <div> <div> Yes, the 6f0359ff73076483902de0c17f9649bf55651e2a I'm referring to is the same as 780605db12c52f2c22d4d2cc05ceb7d2a9d55579 (only exists in amd-staging). </div> So the last of those two commits is the one that causes my problem. <div> </div> <div> Regards </div> <div> //Ernst </div> </div> <div> <div> 2016-10-14 14:53 GMT+02:00 StDenis, Tom <<a href="mailto:Tom.StDenis@amd.com" target="_blank">Tom.StDenis@amd.com</a>>: <div> <div> Does your tree have 2f3d686d0ee95332d8888169c7b6788bb2d9f5ad 780605db12c52f2c22d4d2cc05ceb7d2a9d55579 in it? Those are fixes for when the third ring were added. Tom <div> <div> <div class="MsoNormal" style="text-align:center" align="center"> <hr width="98%" size="2" align="center"> </div> <div id="m_5585073502184114943m_2020318726477089758m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824x_divRplyFwdMsg"> From: amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org" target="_blank">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Ernst Sjöstrand <<a href="mailto:ernstp@gmail.com" target="_blank">ernstp@gmail.com</a>> Sent: Friday, October 14, 2016 08:49 To: <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a> Cc: Ernst Sjöstrand Subject: [PATCH] amdgpu: Fix failing boot after support for third vce ring <div> </div> </div> </div> <div> <div> <div> My Fiji class Fury fails to boot after commit 6f0359ff73076483902de0c17f9649bf55651e2a "drm/amdgpu/vce3: add support for third vce ring" This commits reverts the number of vce rings back to 2, but leaves the other changes intact. Signed-off-by: Ernst Sjöstrand <<a href="mailto:ernstp@gmail.com" target="_blank">ernstp@gmail.com</a>> --- drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c index 3f899e3..6f5eb64 100644 --- a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c +++ b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c @@ -358,7 +358,7 @@ static int vce_v3_0_early_init(void *handle) (AMDGPU_VCE_HARVEST_VCE0 | AMDGPU_VCE_HARVEST_VCE1)) return -ENOENT; - adev->vce.num_rings = 3; + adev->vce.num_rings = 2; vce_v3_0_set_ring_funcs(adev); vce_v3_0_set_irq_funcs(adev); -- 2.7.4 </div> </div> _______________________________________________ amd-gfx mailing list <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="m_5585073502184114943m_2020318726477089758m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824LPlnk959250" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <div style="margin-bottom:15.0pt"> <table class="m_5585073502184114943MsoNormalTable" style="width:90.0%;background:white;border-top:dotted #c8c8c8 1.0pt;border-left:none;border-bottom:dotted #c8c8c8 1.0pt;border-right:none" width="90%" cellspacing="0" cellpadding="0" border="1"> <tbody> <tr> <td style="border:none;padding:0in 0in 0in 0in" valign="top"> <div> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank">amd-gfx Info Page - lists.freedesktop.org</a> </div> <div style="margin-top:7.5pt;margin-bottom:12.0pt" id="m_5585073502184114943m_2020318726477089758m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824LPMetadata_14764495470460.18698958466014992"> <a href="http://lists.freedesktop.org" target="_blank">lists.freedesktop.org</a> </div> <div id="m_5585073502184114943m_2020318726477089758m_-2167022505463390063m_7545045248063895902m_-8133334703298494421m_-1771598304858325824LPDescription_14764495470460.6448197846508978"> To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ... </div> </td> </tr> </tbody> </table> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div></div></div> </div> </div> </blockquote></div> </div>