<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I squashed the phys mode fixes into the original patch patch for upstream:<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><a href="https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.9-wip&id=d7ca7ab8259f43473bc387dda2a5b84aeb049961">https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.9-wip&id=d7ca7ab8259f43473bc387dda2a5b84aeb049961</a><o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Alex<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] <b>On Behalf Of </b>StDenis, Tom<br> <b>Sent:</b> Friday, October 14, 2016 9:17 AM<br> <b>To:</b> Ernst Sjöstrand<br> <b>Cc:</b> amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH] amdgpu: Fix failing boot after support for third vce ring<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p><span style="font-family:"Calibri","sans-serif";color:black">You definitely need the patch from staging-4.7.<o:p></o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black">The "amd-staging-4.x" branches are what we (amd folk) normally develop against on a daily basis and then alex cherry picks them to drm-next-*. Sometimes patches are missed. <o:p></o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black">Hopefully Alex can cherry pick it to drm-next branches shortly <img border="0" width="19" height="19" id="OWAEmoji381116" src="cid:image001.png@01D225FF.BC0D92A0" alt="😊"><o:p></o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black">Tom<o:p></o:p></span></p> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <div> <div class="MsoNormal" align="center" style="text-align:center"><span style="font-family:"Calibri","sans-serif";color:black"> <hr size="2" width="98%" align="center"> </span></div> <div> <p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black"> Ernst Sjöstrand <<a href="mailto:ernstp@gmail.com">ernstp@gmail.com</a>><br> <b>Sent:</b> Friday, October 14, 2016 09:15<br> <b>To:</b> StDenis, Tom<br> <b>Cc:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <b>Subject:</b> Re: [PATCH] amdgpu: Fix failing boot after support for third vce ring</span><span style="font-family:"Calibri","sans-serif";color:black"> <o:p></o:p></span></p> <div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black"> <o:p></o:p></span></p> </div> </div> <div> <div> <div> <div> <div> <div> <div> <div> <div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black">I'm testing both drm-next-4.9 and drm-next-4.9-wip from ~agd5f.<o:p></o:p></span></p> </div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black">I think the problem is in drm-next now also.<o:p></o:p></span></p> </div> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Calibri","sans-serif";color:black">They all have<br> 6f0359f drm/amdgpu/vce3: add support for third vce ring<br> 75c6548 drm/amdgpu: track the number of vce rings<o:p></o:p></span></p> </div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black">But not<br> 9d24b30 drm/amdgpu: fix broken VCE startup in phys mode<o:p></o:p></span></p> </div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black">which only exists in amd-staging-4.7<o:p></o:p></span></p> </div> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Calibri","sans-serif";color:black">(What does 4.7 mean in this context... ?)<o:p></o:p></span></p> </div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black">Regards<o:p></o:p></span></p> </div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black">//Ernst<o:p></o:p></span></p> <div> <div> <div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> </div> </div> </div> </div> <div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black">2016-10-14 15:07 GMT+02:00 StDenis, Tom <<a href="mailto:Tom.StDenis@amd.com" target="_blank">Tom.StDenis@amd.com</a>>:<o:p></o:p></span></p> <div> <div id="m_-8133334703298494421divtagdefaultwrapper"> <p><span style="font-family:"Calibri","sans-serif";color:black">Do you have <a href="https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.7-wip&id=9d24b304abbe5380da1bc782b4460596e7cb1109" target="_blank" id="m_-8133334703298494421LPlnk640528">https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.7-wip&id=9d24b304abbe5380da1bc782b4460596e7cb1109</a> as well?<o:p></o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black">I've booted the tip of our staging-4.7 branch with a FIJI device (FURY) and was able to play videos (vdpau) and normal GL apps.<o:p></o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black">Tom<o:p></o:p></span></p> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <div> <div class="MsoNormal" align="center" style="text-align:center"><span style="font-family:"Calibri","sans-serif";color:black"> <hr size="2" width="98%" align="center"> </span></div> <div id="m_-8133334703298494421divRplyFwdMsg"> <p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black"> Ernst Sjöstrand <<a href="mailto:ernstp@gmail.com" target="_blank">ernstp@gmail.com</a>><br> <b>Sent:</b> Friday, October 14, 2016 09:05<br> <b>To:</b> StDenis, Tom<br> <b>Cc:</b> <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br> <b>Subject:</b> Re: [PATCH] amdgpu: Fix failing boot after support for third vce ring</span><span style="font-family:"Calibri","sans-serif";color:black"> <o:p></o:p></span></p> <div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black"> <o:p></o:p></span></p> </div> </div> <div> <div> <div> <div> <div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black">Yes, the 6f0359ff73076483902de0c17f9649bf55651e2a I'm referring to is the same as <br> 780605db12c52f2c22d4d2cc05ceb7d2a9d55579 (only exists in amd-staging).<o:p></o:p></span></p> </div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black">So the last of those two commits is the one that causes my problem.<o:p></o:p></span></p> <div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black">Regards<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black">//Ernst<o:p></o:p></span></p> </div> </div> <div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black">2016-10-14 14:53 GMT+02:00 StDenis, Tom <<a href="mailto:Tom.StDenis@amd.com" target="_blank">Tom.StDenis@amd.com</a>>:<o:p></o:p></span></p> <div> <div id="m_-8133334703298494421m_-1771598304858325824divtagdefaultwrapper"> <p><span style="font-family:"Calibri","sans-serif";color:black">Does your tree have <o:p></o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black">2f3d686d0ee95332d8888169c7b6788bb2d9f5ad<o:p></o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black">780605db12c52f2c22d4d2cc05ceb7d2a9d55579<o:p></o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black">in it? Those are fixes for when the third ring were added.<o:p></o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <p><span style="font-family:"Calibri","sans-serif";color:black">Tom<o:p></o:p></span></p> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <div> <div> <div class="MsoNormal" align="center" style="text-align:center"><span style="font-family:"Calibri","sans-serif";color:black"> <hr size="2" width="98%" align="center"> </span></div> <div id="m_-8133334703298494421m_-1771598304858325824x_divRplyFwdMsg"> <p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org" target="_blank">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Ernst Sjöstrand <<a href="mailto:ernstp@gmail.com" target="_blank">ernstp@gmail.com</a>><br> <b>Sent:</b> Friday, October 14, 2016 08:49<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br> <b>Cc:</b> Ernst Sjöstrand<br> <b>Subject:</b> [PATCH] amdgpu: Fix failing boot after support for third vce ring</span><span style="font-family:"Calibri","sans-serif";color:black"> <o:p></o:p></span></p> <div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black"> <o:p></o:p></span></p> </div> </div> </div> <div> <div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:black">My Fiji class Fury fails to boot after commit<br> 6f0359ff73076483902de0c17f9649bf55651e2a<br> "drm/amdgpu/vce3: add support for third vce ring"<br> This commits reverts the number of vce rings back to 2,<br> but leaves the other changes intact.<br> <br> Signed-off-by: Ernst Sjöstrand <<a href="mailto:ernstp@gmail.com" target="_blank">ernstp@gmail.com</a>><br> ---<br> drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c<br> index 3f899e3..6f5eb64 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c<br> @@ -358,7 +358,7 @@ static int vce_v3_0_early_init(void *handle)<br> (AMDGPU_VCE_HARVEST_VCE0 | AMDGPU_VCE_HARVEST_VCE1))<br> return -ENOENT;<br> <br> - adev->vce.num_rings = 3;<br> + adev->vce.num_rings = 2;<br> <br> vce_v3_0_set_ring_funcs(adev);<br> vce_v3_0_set_irq_funcs(adev);<br> -- <br> 2.7.4<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:black">_______________________________________________<br> amd-gfx mailing list<br> <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank" id="m_-8133334703298494421m_-1771598304858325824LPlnk959250">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <o:p></o:p></span></p> <div style="margin-bottom:15.0pt;overflow:auto" id="m_-8133334703298494421m_-1771598304858325824LPBorder_GT_14764495470470.9881266530783932"> <table class="MsoNormalTable" border="1" cellspacing="0" cellpadding="0" width="90%" style="width:90.0%;background:white;border-top:dotted #C8C8C8 1.0pt;border-left:none;border-bottom:dotted #C8C8C8 1.0pt;border-right:none"> <tbody> <tr> <td valign="top" style="border:none;padding:0in 0in 0in 0in"> <div id="m_-8133334703298494421m_-1771598304858325824LPTitle_14764495470460.741636132433581"> <p class="MsoNormal" style="margin-top:15.0pt;mso-line-height-alt:15.75pt"><span style="font-size:16.0pt;font-family:"Segoe UI Light","sans-serif";color:#3B5777"><a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank"><span style="text-decoration:none">amd-gfx Info Page - lists.freedesktop.org</span></a><o:p></o:p></span></p> </div> <div style="margin-top:7.5pt;margin-bottom:12.0pt" id="m_-8133334703298494421m_-1771598304858325824LPMetadata_14764495470460.18698958466014992"> <p class="MsoNormal" style="margin-top:15.0pt;line-height:10.5pt"><span style="font-size:10.5pt;font-family:"Segoe UI","sans-serif";color:#666666"><a href="http://lists.freedesktop.org" target="_blank">lists.freedesktop.org</a><o:p></o:p></span></p> </div> <div id="m_-8133334703298494421m_-1771598304858325824LPDescription_14764495470460.6448197846508978"> <p class="MsoNormal" style="margin-top:15.0pt;line-height:15.0pt"><span style="font-size:10.5pt;font-family:"Segoe UI","sans-serif";color:#666666">To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...<o:p></o:p></span></p> </div> </td> </tr> </tbody> </table> </div> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> </div> </div> </div> </div> </div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> </div> </div> </div> </div> </div> </div> </div> </div> <p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> </div> </div> </div> </div> </div> </div> </body> </html>