<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr"> <p>Hi Emil,</p> <p><br> </p> <p>Thing is, with all due respect, the vast majority of DC contributions are likely to come from AMD at the moment. The code is in high flux and requires knowledge about the hardware that the public does not possess.</p> <p><br> </p> <p>That's not to say that submissions aren't welcomed. But on code that is in flux don't be shocked if you get a higher percentage of NAKs than in other parts of the driver which are relatively static.</p> <p><br> </p> <p>It's a bit of a catch. The public (re: Linux) wants open, stable, efficient, and featureful drivers but then they want to dictate to the vendor exactly how that's going to be executed. That doesn't really work in practice or theory. The kernel team has standards that AMD has to meet but the process to get there won't always make everyone happy.</p> <p><br> </p> <p>Once DC is actually cleaned up, validated, and merged into the kernel I suspect the RB/NAK ratio will clean up.</p> <p><br> </p> <p>Cheers,</p> <p>Tom</p> <br> <br> <div style="color: rgb(0, 0, 0);"> <div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Emil Velikov <emil.l.velikov@gmail.com><br> <b>Sent:</b> Monday, December 19, 2016 07:46<br> <b>To:</b> Wentland, Harry<br> <b>Cc:</b> amd-gfx mailing list<br> <b>Subject:</b> Re: [PATCH 2/8] dal: remove some unused wrappers</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">Hi Harry,<br> <br> On 14 December 2016 at 16:26, Harry Wentland <harry.wentland@amd.com> wrote:<br> > They are still used all over the place (e.g.<br> > dc/dce110/dce110_resource.c:413).<br> ><br> > We should at least do an spatch to use kzalloc/krealloc/kfree across the<br> > board if the wrappers are an issue.<br> ><br> > NAKed<br> ><br> [Ignoring all the heat around the DC/DAL topic for a moment]<br> <br> Pardon for reviving this old thread, yet I believe it's beneficial,<br> esp. for the less experienced open-source/kernel devs.<br> <br> There is little-to-no merit of keeping dead code in upstream kernels.<br> That is, unless there's a series in discussion which uses the code ;-)<br> <br> NACKs like this one are not cool, furthermore the tend to<br> alienate/push away people trying to help. With DC/DAL in mind, I think<br> you/others want all the help people can offer ;-)<br> <br> Regards,<br> Emil<br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk955156" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <div id="LPBorder_GT_14821518066090.875104265451631" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;"> <table id="LPContainer_14821518066070.13362218626518296" cellspacing="0" style="width: 90%; background-color: rgb(255, 255, 255); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200);"> <tbody> <tr valign="top" style="border-spacing: 0px;"> <td id="TextCell_14821518066080.7046383869348254" colspan="2" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;"> <div id="LPRemovePreviewContainer_14821518066080.5099265648873654"></div> <div id="LPTitle_14821518066080.5966373441933683" style="top: 0px; color: rgb(59, 87, 119); font-weight: normal; font-size: 21px; font-family: wf_segoe-ui_light, "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;"> <a id="LPUrlAnchor_14821518066090.9322333198849966" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank" style="text-decoration: none;">amd-gfx Info Page - lists.freedesktop.org</a></div> <div id="LPMetadata_14821518066090.3291112186612033" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;"> lists.freedesktop.org</div> <div id="LPDescription_14821518066090.8497682457560758" style="display: block; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;"> To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...</div> </td> </tr> </tbody> </table> </div> <br> <br> </div> </span></font></div> </div> </body> </html>