<div dir="ltr">Ah, I've clicked now - I thought Vega was a star name<div><br></div><div>AI - Arctic Islands :D<br><br><div class="gmail_quote"><div dir="ltr">On Tue, 20 Dec 2016 at 04:07 Bridgman, John <<a href="mailto:John.Bridgman@amd.com">John.Bridgman@amd.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div lang="EN-US" link="blue" vlink="purple" class="gmail_msg"> <div class="m_1273724604454402022WordSection1 gmail_msg"> <p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg">An upcoming GPU generation (Vega).<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p> <p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p> <p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt" class="gmail_msg"> <div class="gmail_msg"> <div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in" class="gmail_msg"> <p class="MsoNormal gmail_msg"><b class="gmail_msg"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class="gmail_msg">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class="gmail_msg"> amd-gfx [mailto:<a href="mailto:amd-gfx-bounces@lists.freedesktop.org" class="gmail_msg" target="_blank">amd-gfx-bounces@lists.freedesktop.org</a>] <b class="gmail_msg">On Behalf Of </b>Mike Lothian<br class="gmail_msg"> <b class="gmail_msg">Sent:</b> Monday, December 19, 2016 10:49 PM<br class="gmail_msg"> <b class="gmail_msg">To:</b> Liu, Monk; <a href="mailto:amd-gfx@lists.freedesktop.org" class="gmail_msg" target="_blank">amd-gfx@lists.freedesktop.org</a><br class="gmail_msg"> <b class="gmail_msg">Subject:</b> Re: [PATCH 02/23] drm/amdgpu: add kiq into compiling<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p> </div> </div></div></div></div><div lang="EN-US" link="blue" vlink="purple" class="gmail_msg"><div class="m_1273724604454402022WordSection1 gmail_msg"><div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt" class="gmail_msg"> <p class="MsoNormal gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></p> <div class="gmail_msg"> <p class="MsoNormal gmail_msg" style="margin-bottom:12.0pt">I'd be curious to know what AI stands for in this context<u class="gmail_msg"></u><u class="gmail_msg"></u></p> <div class="gmail_msg"> <div class="gmail_msg"> <p class="MsoNormal gmail_msg">On Mon, 19 Dec 2016 at 07:28 Liu, Monk <<a href="mailto:Monk.Liu@amd.com" class="gmail_msg" target="_blank">Monk.Liu@amd.com</a>> wrote:<u class="gmail_msg"></u><u class="gmail_msg"></u></p> </div> <blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in" class="gmail_msg"> <p class="MsoNormal gmail_msg">Sorry, NAK for the KIQ implement patches.<br class="gmail_msg"> <br class="gmail_msg"> KIQ is just another compute queue, and each generation of compute queue initialization is different, so there is no need of a amdgpu_kiq.c file to cover the function of kiq,<br class="gmail_msg"> <br class="gmail_msg"> Kiq is good enough to be in each gfx_x_x.c file .e.g :<br class="gmail_msg"> KIQ for VI is in gfx_v8_0.c<br class="gmail_msg"> And KIQ for AI is in gfx_v9_0.c<br class="gmail_msg"> <br class="gmail_msg"> Most important is that the "queue_init" routine of above two chips on KIQ is different (MQD descriptor as well as registers need programing ... ), please just align with the previous patch style in amd-sriov-4.6 for KIQ part<br class="gmail_msg"> <br class="gmail_msg"> BR Monk<br class="gmail_msg"> <br class="gmail_msg"> -----<span style="font-family:MingLiU" class="gmail_msg">邮件原件</span>-----<br class="gmail_msg"> <span style="font-family:MingLiU" class="gmail_msg">发件人</span>: Yu, Xiangliang<br class="gmail_msg"> <span style="font-family:MingLiU" class="gmail_msg">发送时间</span>: Sunday, December 18, 2016 9:47 AM<br class="gmail_msg"> <span style="font-family:"MS Gothic"" class="gmail_msg">收件人</span>: dl.SRDC_SW_GPUVirtualization<br class="gmail_msg"> <span style="font-family:"MS Gothic"" class="gmail_msg">主</span><span style="font-family:MingLiU" class="gmail_msg">题</span>: FW: [PATCH 02/23] drm/amdgpu: add kiq into compiling<br class="gmail_msg"> <br class="gmail_msg"> <br class="gmail_msg"> <br class="gmail_msg"> -----Original Message-----<br class="gmail_msg"> From: Xiangliang Yu [mailto:<a href="mailto:Xiangliang.Yu@amd.com" class="gmail_msg" target="_blank">Xiangliang.Yu@amd.com</a>]<br class="gmail_msg"> Sent: Sunday, December 18, 2016 12:16 AM<br class="gmail_msg"> To: <a href="mailto:amd-gfx@lists.freedesktop.org" class="gmail_msg" target="_blank">amd-gfx@lists.freedesktop.org</a>; dl.SRDC_SW_GPUVirtualization <<a href="mailto:dl.SRDC_SW_GPUVirtualization@amd.com" class="gmail_msg" target="_blank">dl.SRDC_SW_GPUVirtualization@amd.com</a>><br class="gmail_msg"> Cc: Yu, Xiangliang <<a href="mailto:Xiangliang.Yu@amd.com" class="gmail_msg" target="_blank">Xiangliang.Yu@amd.com</a>><br class="gmail_msg"> Subject: [PATCH 02/23] drm/amdgpu: add kiq into compiling<br class="gmail_msg"> <br class="gmail_msg"> Add support KIQ in Makefile to make it into module.<br class="gmail_msg"> <br class="gmail_msg"> Signed-off-by: Xiangliang Yu <<a href="mailto:Xiangliang.Yu@amd.com" class="gmail_msg" target="_blank">Xiangliang.Yu@amd.com</a>><br class="gmail_msg"> ---<br class="gmail_msg"> drivers/gpu/drm/amd/amdgpu/Makefile | 2 +-<br class="gmail_msg"> 1 file changed, 1 insertion(+), 1 deletion(-)<br class="gmail_msg"> <br class="gmail_msg"> diff --git a/drivers/gpu/drm/amd/amdgpu/Makefile b/drivers/gpu/drm/amd/amdgpu/Makefile<br class="gmail_msg"> index dd0b6db..635ff94 100644<br class="gmail_msg"> --- a/drivers/gpu/drm/amd/amdgpu/Makefile<br class="gmail_msg"> +++ b/drivers/gpu/drm/amd/amdgpu/Makefile<br class="gmail_msg"> @@ -30,7 +30,7 @@ amdgpu-y += amdgpu_device.o amdgpu_kms.o \<br class="gmail_msg"> atombios_encoders.o amdgpu_sa.o atombios_i2c.o \<br class="gmail_msg"> amdgpu_prime.o amdgpu_vm.o amdgpu_ib.o amdgpu_pll.o \<br class="gmail_msg"> amdgpu_ucode.o amdgpu_bo_list.o amdgpu_ctx.o amdgpu_sync.o \<br class="gmail_msg"> - amdgpu_gtt_mgr.o amdgpu_vram_mgr.o<br class="gmail_msg"> + amdgpu_gtt_mgr.o amdgpu_vram_mgr.o amdgpu_kiq.o<br class="gmail_msg"> <br class="gmail_msg"> # add asic specific block<br class="gmail_msg"> amdgpu-$(CONFIG_DRM_AMDGPU_CIK)+= cik.o cik_ih.o kv_smc.o kv_dpm.o \<br class="gmail_msg"> --<br class="gmail_msg"> 2.7.4<br class="gmail_msg"> <br class="gmail_msg"> _______________________________________________<br class="gmail_msg"> amd-gfx mailing list<br class="gmail_msg"> <a href="mailto:amd-gfx@lists.freedesktop.org" class="gmail_msg" target="_blank">amd-gfx@lists.freedesktop.org</a><br class="gmail_msg"> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" class="gmail_msg" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><u class="gmail_msg"></u><u class="gmail_msg"></u></p> </blockquote> </div> </div> </div></div></div></blockquote></div></div></div>