<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
text-align:justify;
text-justify:inter-ideograph;
font-size:10.5pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.5pt;
font-family:"Calibri","sans-serif";}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0cm;
margin-bottom:.0001pt;
text-align:justify;
text-justify:inter-ideograph;
font-size:8.0pt;
font-family:"Calibri","sans-serif";}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri","sans-serif";}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
/* Page Definitions */
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-CN" link="blue" vlink="purple" style="text-justify-trim:punctuation">
<div class="WordSection1">
<p class="MsoPlainText"><span lang="EN-US">Sorry, update.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">User just need to know the cg/pg feature</span><span lang="EN-US" style="font-family:"Courier New"">’</span><span lang="EN-US">s state(enable/disable), not current CG state.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Best Regards<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Rex<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">-----Original Message-----<br>
From: Zhu, Rex <br>
Sent: Thursday, January 05, 2017 11:34 AM<br>
To: Huang, Ray; Deucher, Alexander<br>
Cc: amd-gfx@lists.freedesktop.org; Mao, David; Fu, Ping<br>
Subject: RE: [PATCH] drm/amdgpu: show gfx clock gating status to user</span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">As talked with David. They not only need to know whether the CG/PG is supported, but also need to know <span style="color:#00B050">those features state(enabled/disabled)
</span>(not <span style="color:red">current CG/PG state)</span>. <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">we added the profile mode, so in runtime, user can disable/enable cg.
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Then user wanted to confirm the feature</span><span lang="EN-US" style="font-family:"Courier New"">’</span><span lang="EN-US">s state<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">So we may need to export cg/pg mask and feature</span><span lang="EN-US" style="font-family:"Courier New"">’</span><span lang="EN-US">s state.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Best Regards<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Rex<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">-----Original Message-----<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">From: Huang Rui [<a href="mailto:ray.huang@amd.com"><span style="color:windowtext;text-decoration:none">mailto:ray.huang@amd.com</span></a>]<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Sent: Wednesday, January 04, 2017 10:22 AM<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">To: Deucher, Alexander<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Cc: <a href="mailto:amd-gfx@lists.freedesktop.org">
<span style="color:windowtext;text-decoration:none">amd-gfx@lists.freedesktop.org</span></a>; Zhu, Rex; Mao, David; Fu, Ping<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Subject: Re: [PATCH] drm/amdgpu: show gfx clock gating status to user<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">On Tue, Jan 03, 2017 at 11:02:09PM +0800, Deucher, Alexander wrote:<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > -----Original Message-----<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > From: Huang Rui [<a href="mailto:ray.huang@amd.com"><span style="color:windowtext;text-decoration:none">mailto:ray.huang@amd.com</span></a>]<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > Sent: Tuesday, January 03, 2017 5:47 AM<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > To: Deucher, Alexander; <a href="mailto:amd-gfx@lists.freedesktop.org">
<span style="color:windowtext;text-decoration:none">amd-gfx@lists.freedesktop.org</span></a><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > Cc: Zhu, Rex; Mao, David; Fu, Ping; Huang, Ray<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > Subject: [PATCH] drm/amdgpu: show gfx clock gating status to user<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > Signed-off-by: Huang Rui <<a href="mailto:ray.huang@amd.com"><span style="color:windowtext;text-decoration:none">ray.huang@amd.com</span></a>><o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > ---<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 5 +++++
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 2 ++
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 2 ++
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 3 +++<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > 5 files changed, 13 insertions(+)<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > b/drivers/gpu/drm/amd/amdgpu/amdgpu.h<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > index 96eeea7..989d311 100644<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > @@ -1033,6 +1033,7 @@ struct amdgpu_gfx {<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > struct amdgpu_irq_src priv_inst_irq;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > /* gfx status */<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > uint32_t gfx_current_status;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > + bool cg_enabled;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > /* ce ram size*/<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > unsigned ce_ram_size;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > struct amdgpu_cu_info cu_info;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > index a7c7657..10f2eab 100644<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > @@ -1543,6 +1543,11 @@ static int amdgpu_debugfs_pm_info(struct
<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > seq_file *m, void *data)<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > struct amdgpu_device *adev = dev->dev_private;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > struct drm_device *ddev = adev->ddev;<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > + if (adev->gfx.cg_enabled)<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > + seq_printf(m, "GFX Clock Gating: Enabled\n");<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > + else<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > + seq_printf(m, "GFX Clock Gating: Disabled\n");<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> > +<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> I think it would be better to print the cg_flags and pg_flags (both as a mask and in human readable form) so we know exactly cg and pg features are enabled.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">> <o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">It's probable better. Let me revise this patch and send it later.<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Thanks,<o:p></o:p></span></p>
<p class="MsoPlainText"><span lang="EN-US">Rui<o:p></o:p></span></p>
</div>
</body>
</html>