<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr"> <p>Hi Emil,</p> <p><br> </p> <p>Thanks for the advice. I noticed that you have changed some tests using <span> drmGetDevices2</span>.</p> <p>I mark this to my to do list.<br> </p> <p><br> </p> <p>Thanks,</p> <p>Alex Bin Xie<br> </p> <br> <div style="color: rgb(0, 0, 0);"> <div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> Emil Velikov <emil.l.velikov@gmail.com><br> <b>Sent:</b> Thursday, January 12, 2017 2:26 PM<br> <b>To:</b> Edward O'Callaghan<br> <b>Cc:</b> Xie, AlexBin; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: More specific libdrm error message</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">On 12 January 2017 at 01:29, Edward O'Callaghan<br> <funfunctor@folklore1984.net> wrote:<br> > Hi Xie,<br> ><br> > Perhaps you want to use `fprintf(stderr, "...")` over `printf("..")` and<br> > lose the space before the start parenthesis. Also, line wrap<br> > your commit message.<br> ><br> > Side note, use git send-email so that the patch is inline and not a HTML<br> > email for easy review and application of the patch.<br> ><br> Thanks Edward.<br> <br> Xie, suggesting to run almost anything as root is a bad idea ;-)<br> Instead one could auth, in order to have the correct permissions.<br> Alternatively can use the renderD node all together.<br> <br> Idea for future work:<br> Would be even better to use drmGetDevices2 to fetch all the devices<br> and use the correct node since card0/renderD128 is not guaranteed to<br> be a amdgpu one. Or maybe even run all the amdgpu devices through the<br> tests ?<br> <br> Please correctly wrap commit messages and code.<br> <br> Thanks<br> Emil<br> </div> </span></font></div> </div> </body> </html>