<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr"> <p>Coo, pushed to staging.</p> <p><br> </p> <p>Tom</p> <br> <br> <div style="color: rgb(0, 0, 0);"> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Deucher, Alexander<br> <b>Sent:</b> Wednesday, January 18, 2017 13:47<br> <b>To:</b> StDenis, Tom; Alex Deucher<br> <b>Cc:</b> amd-gfx list<br> <b>Subject:</b> RE: [PATCH] drm/amd/amdgpu: Add PCI info to gca_config debugfs</font> <div> </div> </div> <div> <div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:#1F497D">Whoops, sorry, I glanced quickly and thought you were grabbing the vendor and device ids, not the revision. Carry on </span><span style="font-size:11.0pt; font-family:Wingdings; color:#1F497D">J</span><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:#1F497D"></span></p> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:#1F497D"> </span></p> <div style="border:none; border-left:solid blue 1.5pt; padding:0in 0in 0in 4.0pt"> <div> <div style="border:none; border-top:solid #B5C4DF 1.0pt; padding:3.0pt 0in 0in 0in"> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif""> amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] <b>On Behalf Of </b>StDenis, Tom<br> <b>Sent:</b> Wednesday, January 18, 2017 1:45 PM<br> <b>To:</b> Alex Deucher<br> <b>Cc:</b> amd-gfx list<br> <b>Subject:</b> Re: [PATCH] drm/amd/amdgpu: Add PCI info to gca_config debugfs</span></p> </div> </div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> </p> <div id="divtagdefaultwrapper"> <p><span style="font-family:"Calibri","sans-serif"; color:black">I am grabbing revision. Unless there's some other PCI revision value I'm missing :-)</span></p> <p><span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <p><span style="font-family:"Calibri","sans-serif"; color:black">Tom</span></p> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <div> <div> <div align="center" style="text-align: center; margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-family:"Calibri","sans-serif"; color:black"> <hr size="2" width="98%" align="center"> </span></div> <div id="x_divRplyFwdMsg"> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <b><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:black">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:black"> Alex Deucher <<a href="mailto:alexdeucher@gmail.com" style="color: blue; text-decoration: underline;">alexdeucher@gmail.com</a>><br> <b>Sent:</b> Wednesday, January 18, 2017 13:40<br> <b>To:</b> Tom St Denis<br> <b>Cc:</b> amd-gfx list; StDenis, Tom<br> <b>Subject:</b> Re: [PATCH] drm/amd/amdgpu: Add PCI info to gca_config debugfs</span><span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> </div> </div> </div> <div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:10.0pt; font-family:"Calibri","sans-serif"; color:black">On Wed, Jan 18, 2017 at 1:25 PM, Tom St Denis <<a href="mailto:tstdenis82@gmail.com" style="color: blue; text-decoration: underline;">tstdenis82@gmail.com</a>> wrote:<br> > So we can determine which device the entry is before connecting<br> > a display.<br> ><br> > Signed-off-by: Tom St Denis <<a href="mailto:tom.stdenis@amd.com" style="color: blue; text-decoration: underline;">tom.stdenis@amd.com</a>><br> > ---<br> > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++++++-<br> > 1 file changed, 7 insertions(+), 1 deletion(-)<br> ><br> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br> > index 28681286d57c..8640f9216d93 100644<br> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br> > @@ -2967,7 +2967,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,<br> > return -ENOMEM;<br> ><br> > /* version, increment each time something is added */<br> > - config[no_regs++] = 2;<br> > + config[no_regs++] = 3;<br> > config[no_regs++] = adev->gfx.config.max_shader_engines;<br> > config[no_regs++] = adev->gfx.config.max_tile_pipes;<br> > config[no_regs++] = adev->gfx.config.max_cu_per_sh;<br> > @@ -3001,6 +3001,12 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,<br> > config[no_regs++] = adev->family;<br> > config[no_regs++] = adev->external_rev_id;<br> ><br> > + /* rev==3 */<br> > + config[no_regs++] = adev->pdev->device;<br> > + config[no_regs++] = adev->pdev->revision;<br> > + config[no_regs++] = adev->pdev->subsystem_device;<br> > + config[no_regs++] = adev->pdev->subsystem_vendor;<br> <br> For completeness, please add pdev->revision as well. With that:<br> Reviewed-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com" style="color: blue; text-decoration: underline;">alexander.deucher@amd.com</a>><br> <br> > +<br> > while (size && (*pos < no_regs * 4)) {<br> > uint32_t value;<br> ><br> > --<br> > 2.11.0<br> ><br> > _______________________________________________<br> > amd-gfx mailing list<br> > <a href="mailto:amd-gfx@lists.freedesktop.org" style="color: blue; text-decoration: underline;"> amd-gfx@lists.freedesktop.org</a><br> > <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk654617" style="color: blue; text-decoration: underline;" previewremoved="true"> https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> </span></p> <div id="LPBorder_GT_14847650573060.6184570050595048" style="margin-bottom:15.0pt; overflow:auto"> <table class="MsoNormalTable" border="1" cellspacing="0" cellpadding="0" width="90%" style="width:90.0%; background:white; border-top:dotted #C8C8C8 1.0pt; border-left:none; border-bottom:dotted #C8C8C8 1.0pt; border-right:none"> <tbody> <tr> <td valign="top" style="border:none; padding:0in 0in 0in 0in"> <div id="LPTitle_14847650573050.01429245096647258"> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:16.0pt; font-family:"Segoe UI Light","sans-serif"; color:#3B5777"><a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank" style="color: blue; text-decoration: underline;"><span style="text-decoration:none">amd-gfx Info Page - lists.freedesktop.org</span></a></span></p> </div> <div id="LPMetadata_14847650573050.012810323802504353" style="margin-top:7.5pt; margin-bottom:12.0pt"> <p style="line-height: 10.5pt; margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:10.5pt; font-family:"Segoe UI","sans-serif"; color:#666666">lists.freedesktop.org</span></p> </div> <div id="LPDescription_14847650573060.29801268163925165"> <p style="line-height: 15pt; margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:10.5pt; font-family:"Segoe UI","sans-serif"; color:#666666">To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...</span></p> </div> </td> </tr> </tbody> </table> </div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:10.0pt; font-family:"Calibri","sans-serif"; color:black"> </span></p> </div> </div> </div> </div> </div> </div> </div> </div> </body> </html>