<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr"> <p>I am grabbing revision. Unless there's some other PCI revision value I'm missing :-)</p> <p><br> </p> <p>Tom</p> <br> <br> <div style="color: rgb(0, 0, 0);"> <div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Alex Deucher <alexdeucher@gmail.com><br> <b>Sent:</b> Wednesday, January 18, 2017 13:40<br> <b>To:</b> Tom St Denis<br> <b>Cc:</b> amd-gfx list; StDenis, Tom<br> <b>Subject:</b> Re: [PATCH] drm/amd/amdgpu: Add PCI info to gca_config debugfs</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">On Wed, Jan 18, 2017 at 1:25 PM, Tom St Denis <tstdenis82@gmail.com> wrote:<br> > So we can determine which device the entry is before connecting<br> > a display.<br> ><br> > Signed-off-by: Tom St Denis <tom.stdenis@amd.com><br> > ---<br> > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++++++-<br> > 1 file changed, 7 insertions(+), 1 deletion(-)<br> ><br> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br> > index 28681286d57c..8640f9216d93 100644<br> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br> > @@ -2967,7 +2967,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,<br> > return -ENOMEM;<br> ><br> > /* version, increment each time something is added */<br> > - config[no_regs++] = 2;<br> > + config[no_regs++] = 3;<br> > config[no_regs++] = adev->gfx.config.max_shader_engines;<br> > config[no_regs++] = adev->gfx.config.max_tile_pipes;<br> > config[no_regs++] = adev->gfx.config.max_cu_per_sh;<br> > @@ -3001,6 +3001,12 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,<br> > config[no_regs++] = adev->family;<br> > config[no_regs++] = adev->external_rev_id;<br> ><br> > + /* rev==3 */<br> > + config[no_regs++] = adev->pdev->device;<br> > + config[no_regs++] = adev->pdev->revision;<br> > + config[no_regs++] = adev->pdev->subsystem_device;<br> > + config[no_regs++] = adev->pdev->subsystem_vendor;<br> <br> For completeness, please add pdev->revision as well. With that:<br> Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br> <br> > +<br> > while (size && (*pos < no_regs * 4)) {<br> > uint32_t value;<br> ><br> > --<br> > 2.11.0<br> ><br> > _______________________________________________<br> > amd-gfx mailing list<br> > amd-gfx@lists.freedesktop.org<br> > <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk654617" previewremoved="true"> https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <div id="LPBorder_GT_14847650573060.6184570050595048" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;"> <table id="LPContainer_14847650573040.2543156100021653" cellspacing="0" style="width: 90%; background-color: rgb(255, 255, 255); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200);"> <tbody> <tr valign="top" style="border-spacing: 0px;"> <td id="TextCell_14847650573050.6209665506878967" colspan="2" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;"> <div id="LPRemovePreviewContainer_14847650573050.4249670139356132"></div> <div id="LPTitle_14847650573050.01429245096647258" style="top: 0px; color: rgb(59, 87, 119); font-weight: normal; font-size: 21px; font-family: wf_segoe-ui_light, "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;"> <a id="LPUrlAnchor_14847650573050.26124938264084885" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank" style="text-decoration: none;">amd-gfx Info Page - lists.freedesktop.org</a></div> <div id="LPMetadata_14847650573050.012810323802504353" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;"> lists.freedesktop.org</div> <div id="LPDescription_14847650573060.29801268163925165" style="display: block; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;"> To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...</div> </td> </tr> </tbody> </table> </div> <br> <br> </div> </span></font></div> </div> </body> </html>