<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr"> <p>Thanks Alex and Christian.</p> <p><br> </p> <p>Patch7 is just a workaround for issue: when dpm disabled, can't initialize uvd on Ci. </p> <p>Now I have found the root cause. so no need to add timeout time. </p> <p><br> </p> <p>Please review the attached patch. </p> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr"> <span style="font-size: 12pt;"><br> </span></div> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr"> <span style="font-size: 12pt;">Best Regards</span></div> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr"> Rex</div> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr"> <div></div> <br> </div> <br> <div style="color: rgb(0, 0, 0);"> <div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Christian König <deathsimple@vodafone.de><br> <b>Sent:</b> Friday, January 27, 2017 4:34 PM<br> <b>To:</b> Zhu, Rex; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH 00/12] mise patch related uvd/vce cg and pg.</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">I only skimmed over it, but what I saw looked mostly good to me.<br> <br> Patch #7: Please add a code comment explaining why we do this.<br> <br> Apart from that the rest is Acked-by: Christian König <br> <christian.koenig@amd.com>.<br> <br> Regards,<br> Christian.<br> <br> Am 26.01.2017 um 12:00 schrieb Rex Zhu:<br> > Rex Zhu (12):<br> > drm/amdgpu: when dpm disabled, also can enable uvd cg/pg.<br> > drm/amdgpu: add current_pg_status register define for smu7.1<br> > drm/amdgpu: power down/up uvd4 when smu disabled.<br> > drm/amdgpu: refine uvd pg code in kv_dpm.c<br> > drm/amdgpu: refine uvd4.2 init/stop code.<br> > drm/amdgpu: refine uvd5.0/6.0 code.<br> > drm/amdgpu: add uvd timeout time.<br> > drm/amdgpu: when dpm disabled, also need to stop/start vce.<br> > drm/amdgpu: refine code for VCE2.0 and related dpm code.<br> > drm/amdgpu: enable vce pg feature on Kv.<br> > drm/amdgpu: move subfunctions to the front of vce_v2_0.c.<br> > drm/amdgpu: refine vce3.0 code and related powerplay pg code.<br> ><br> > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 12 +-<br> > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 12 +-<br> > drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 9 +<br> > drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 9 -<br> > drivers/gpu/drm/amd/amdgpu/cik.c | 4 +-<br> > drivers/gpu/drm/amd/amdgpu/kv_dpm.c | 68 +---<br> > drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 130 ++++--<br> > drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 24 +-<br> > drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 21 +-<br> > drivers/gpu/drm/amd/amdgpu/vce_v2_0.c | 451 +++++++++++----------<br> > drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 17 +-<br> > .../gpu/drm/amd/include/asic_reg/smu/smu_7_0_1_d.h | 1 +<br> > .../drm/amd/powerplay/hwmgr/cz_clockpowergating.c | 71 ++--<br> > .../amd/powerplay/hwmgr/smu7_clockpowergating.c | 23 +-<br> > 14 files changed, 438 insertions(+), 414 deletions(-)<br> ><br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk95829" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <div id="LPBorder_GT_14861233545480.24770334642380476" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;"> <table id="LPContainer_14861233545370.7303266131784767" cellspacing="0" style="width: 90%; position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top-width: 1px; border-top-style: dotted; border-top-color: rgb(200, 200, 200); border-bottom-width: 1px; border-bottom-style: dotted; border-bottom-color: rgb(200, 200, 200); background-color: rgb(255, 255, 255);"> <tbody> <tr valign="top" style="border-spacing: 0px;"> <td id="TextCell_14861233545420.6267699955496937" colspan="2" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;"> <div id="LPRemovePreviewContainer_14861233545420.5892529881093651"></div> <div id="LPTitle_14861233545420.3257206380367279" style="top: 0px; color: rgb(0, 120, 215); font-weight: normal; font-size: 21px; font-family: wf_segoe-ui_light, 'Segoe UI Light', 'Segoe WP Light', 'Segoe UI', 'Segoe WP', Tahoma, Arial, sans-serif; line-height: 21px;"> <a id="LPUrlAnchor_14861233545440.7875377230811864" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank" style="text-decoration: none;">amd-gfx Info Page - lists.freedesktop.org</a></div> <div id="LPMetadata_14861233545440.3748800181783736" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, 'Segoe UI', 'Segoe WP', Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;"> lists.freedesktop.org</div> <div id="LPDescription_14861233545450.265732379630208" style="display: block; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, 'Segoe UI', 'Segoe WP', Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;"> To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...</div> </td> </tr> </tbody> </table> </div> <br> <br> </div> </span></font></div> </div> </body> </html>