<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"Segoe UI";
panose-1:2 11 5 2 4 2 4 2 2 3;}
@font-face
{font-family:"Segoe UI Light";
panose-1:2 11 5 2 4 2 4 2 2 3;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Reviewed-by: Alex Deucher <alexander.deucher@amd.com><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org]
<b>On Behalf Of </b>Zhu, Rex<br>
<b>Sent:</b> Friday, February 03, 2017 7:10 AM<br>
<b>To:</b> Christian König; amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Alex Deucher<br>
<b>Subject:</b> Re: [PATCH 00/12] mise patch related uvd/vce cg and pg.<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div id="divtagdefaultwrapper">
<p><span style="font-family:"Calibri","sans-serif";color:black">Thanks Alex and Christian.<o:p></o:p></span></p>
<p><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p>
<p><span style="font-family:"Calibri","sans-serif";color:black">Patch7 is just a workaround for issue: when dpm disabled, can't initialize uvd on Ci. <o:p></o:p></span></p>
<p><span style="font-family:"Calibri","sans-serif";color:black">Now I have found the root cause. so no need to add timeout time. <o:p></o:p></span></p>
<p><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p>
<p><span style="font-family:"Calibri","sans-serif";color:black">Please review the attached patch. <o:p></o:p></span></p>
<div id="divtagdefaultwrapper">
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p>
</div>
<div id="divtagdefaultwrapper">
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black">Best Regards<o:p></o:p></span></p>
</div>
<div id="divtagdefaultwrapper">
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black">Rex<o:p></o:p></span></p>
</div>
<div id="divtagdefaultwrapper">
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p>
</div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p>
<div>
<div>
<div class="MsoNormal" align="center" style="text-align:center"><span style="font-family:"Calibri","sans-serif";color:black">
<hr size="2" width="98%" align="center">
</span></div>
<div id="x_divRplyFwdMsg">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>>
on behalf of Christian König <<a href="mailto:deathsimple@vodafone.de">deathsimple@vodafone.de</a>><br>
<b>Sent:</b> Friday, January 27, 2017 4:34 PM<br>
<b>To:</b> Zhu, Rex; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br>
<b>Subject:</b> Re: [PATCH 00/12] mise patch related uvd/vce cg and pg.</span><span style="font-family:"Calibri","sans-serif";color:black">
<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif";color:black"> <o:p></o:p></span></p>
</div>
</div>
</div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:black">I only skimmed over it, but what I saw looked mostly good to me.<br>
<br>
Patch #7: Please add a code comment explaining why we do this.<br>
<br>
Apart from that the rest is Acked-by: Christian König <br>
<<a href="mailto:christian.koenig@amd.com">christian.koenig@amd.com</a>>.<br>
<br>
Regards,<br>
Christian.<br>
<br>
Am 26.01.2017 um 12:00 schrieb Rex Zhu:<br>
> Rex Zhu (12):<br>
> drm/amdgpu: when dpm disabled, also can enable uvd cg/pg.<br>
> drm/amdgpu: add current_pg_status register define for smu7.1<br>
> drm/amdgpu: power down/up uvd4 when smu disabled.<br>
> drm/amdgpu: refine uvd pg code in kv_dpm.c<br>
> drm/amdgpu: refine uvd4.2 init/stop code.<br>
> drm/amdgpu: refine uvd5.0/6.0 code.<br>
> drm/amdgpu: add uvd timeout time.<br>
> drm/amdgpu: when dpm disabled, also need to stop/start vce.<br>
> drm/amdgpu: refine code for VCE2.0 and related dpm code.<br>
> drm/amdgpu: enable vce pg feature on Kv.<br>
> drm/amdgpu: move subfunctions to the front of vce_v2_0.c.<br>
> drm/amdgpu: refine vce3.0 code and related powerplay pg code.<br>
><br>
> drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 12 +-<br>
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 12 +-<br>
> drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 9 +<br>
> drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 9 -<br>
> drivers/gpu/drm/amd/amdgpu/cik.c | 4 +-<br>
> drivers/gpu/drm/amd/amdgpu/kv_dpm.c | 68 +---<br>
> drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 130 ++++--<br>
> drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 24 +-<br>
> drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 21 +-<br>
> drivers/gpu/drm/amd/amdgpu/vce_v2_0.c | 451 +++++++++++----------<br>
> drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 17 +-<br>
> .../gpu/drm/amd/include/asic_reg/smu/smu_7_0_1_d.h | 1 +<br>
> .../drm/amd/powerplay/hwmgr/cz_clockpowergating.c | 71 ++--<br>
> .../amd/powerplay/hwmgr/smu7_clockpowergating.c | 23 +-<br>
> 14 files changed, 438 insertions(+), 414 deletions(-)<br>
><br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk95829">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
<o:p></o:p></span></p>
<div style="margin-bottom:15.0pt;overflow:auto" id="LPBorder_GT_14861233545480.24770334642380476">
<table class="MsoNormalTable" border="1" cellspacing="0" cellpadding="0" width="90%" style="width:90.0%;background:white;border-top:dotted #C8C8C8 1.0pt;border-left:none;border-bottom:dotted #C8C8C8 1.0pt;border-right:none">
<tbody>
<tr>
<td valign="top" style="border:none;padding:0in 0in 0in 0in">
<div id="LPTitle_14861233545420.3257206380367279">
<p class="MsoNormal" style="margin-top:15.0pt;mso-line-height-alt:15.75pt"><span style="font-size:16.0pt;font-family:"Segoe UI Light","sans-serif";color:#0078D7"><a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank"><span style="text-decoration:none">amd-gfx
Info Page - lists.freedesktop.org</span></a><o:p></o:p></span></p>
</div>
<div style="margin-top:7.5pt;margin-bottom:12.0pt" id="LPMetadata_14861233545440.3748800181783736">
<p class="MsoNormal" style="margin-top:15.0pt;line-height:10.5pt"><span style="font-size:10.5pt;font-family:"Segoe UI","sans-serif";color:#666666">lists.freedesktop.org<o:p></o:p></span></p>
</div>
<div id="LPDescription_14861233545450.265732379630208">
<p class="MsoNormal" style="margin-top:15.0pt;line-height:15.0pt"><span style="font-size:10.5pt;font-family:"Segoe UI","sans-serif";color:#666666">To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message
to all the list members, send email ...<o:p></o:p></span></p>
</div>
</td>
</tr>
</tbody>
</table>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p>
</div>
</div>
</div>
</div>
</div>
</body>
</html>