<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=gb2312">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Arial,Helvetica,sans-serif">
<p>FIJI is not supported in current stack</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>发件人:</b> Yu, Xiangliang<br>
<b>发送时间:</b> 2017年2月6日 10:35:34<br>
<b>收件人:</b> Liu, Monk; amd-gfx@lists.freedesktop.org<br>
<b>抄送:</b> Liu, Monk<br>
<b>主题:</b> RE: [PATCH 02/21] drm/amdgpu:fix golden init for sriov</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Does FIJI need the golden init?<br>
<br>
<br>
Thanks!<br>
Xiangliang Yu<br>
<br>
> -----Original Message-----<br>
> From: amd-gfx [<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">mailto:amd-gfx-bounces@lists.freedesktop.org</a>] On Behalf<br>
> Of Monk Liu<br>
> Sent: Saturday, February 04, 2017 6:22 PM<br>
> To: amd-gfx@lists.freedesktop.org<br>
> Cc: Liu, Monk <Monk.Liu@amd.com><br>
> Subject: [PATCH 02/21] drm/amdgpu:fix golden init for sriov<br>
> <br>
> although only vi supports SRIOV now,but we shouldn't make code has such<br>
> assumption.<br>
> <br>
> Change-Id: Ie73c185dc2e7f64756253045b32cabe70d618d19<br>
> Signed-off-by: Monk Liu <Monk.Liu@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/vi.c | 11 ++++-------<br>
> 1 file changed, 4 insertions(+), 7 deletions(-)<br>
> <br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c<br>
> b/drivers/gpu/drm/amd/amdgpu/vi.c index 89b0dfe..7810030 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/vi.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/vi.c<br>
> @@ -274,12 +274,6 @@ static void vi_init_golden_registers(struct<br>
> amdgpu_device *adev)<br>
> /* Some of the registers might be dependent on GRBM_GFX_INDEX<br>
> */<br>
> mutex_lock(&adev->grbm_idx_mutex);<br>
> <br>
> - if (amdgpu_sriov_vf(adev)) {<br>
> - xgpu_vi_init_golden_registers(adev);<br>
> - mutex_unlock(&adev->grbm_idx_mutex);<br>
> - return;<br>
> - }<br>
> -<br>
> switch (adev->asic_type) {<br>
> case CHIP_TOPAZ:<br>
> amdgpu_program_register_sequence(adev,<br>
> @@ -292,7 +286,10 @@ static void vi_init_golden_registers(struct<br>
> amdgpu_device *adev)<br>
> (const<br>
> u32)ARRAY_SIZE(fiji_mgcg_cgcg_init));<br>
> break;<br>
> case CHIP_TONGA:<br>
> - amdgpu_program_register_sequence(adev,<br>
> + if (amdgpu_sriov_vf(adev))<br>
> + xgpu_vi_init_golden_registers(adev);<br>
> + else<br>
> + amdgpu_program_register_sequence(adev,<br>
> tonga_mgcg_cgcg_init,<br>
> (const<br>
> u32)ARRAY_SIZE(tonga_mgcg_cgcg_init));<br>
> break;<br>
> --<br>
> 2.7.4<br>
> <br>
> _______________________________________________<br>
> amd-gfx mailing list<br>
> amd-gfx@lists.freedesktop.org<br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font>
</body>
</html>