<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Arial,Helvetica,sans-serif">
<p>yeah, make sense</p>
<p>@Christian, why move fbdev_init() further down after ib test ? any consideration ?<br>
</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>发件人:</b> Michel Dänzer <michel@daenzer.net><br>
<b>发送时间:</b> 2017年2月8日 23:19:23<br>
<b>收件人:</b> Christian König; Liu, Monk<br>
<b>抄送:</b> amd-gfx@lists.freedesktop.org<br>
<b>主题:</b> Re: [PATCH] drm/amdgpu:fix amdgpu_sa_bo_new error</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">On 08/02/17 07:52 PM, Christian König wrote:<br>
> Am 08.02.2017 um 10:41 schrieb Monk Liu:<br>
>> ib_pool init should prior to fbdev_init, otherwise<br>
>> there will be error from amdgpu_sa_bo_new<br>
>> (amdgpu_sa.c:323)<br>
>><br>
>> fbdev_init will call ttm_validate which further call<br>
>> amdgpu_sa_bo_new.<br>
>><br>
>> Change-Id: I3a969570d443f61a44f67b0d76b3871ca5c3ea81<br>
>> Signed-off-by: Monk Liu <Monk.Liu@amd.com><br>
>> ---<br>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--<br>
>> 1 file changed, 2 insertions(+), 2 deletions(-)<br>
>><br>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
>> index afcae15..4169bb1 100644<br>
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
>> @@ -1918,14 +1918,14 @@ int amdgpu_device_init(struct amdgpu_device<br>
>> *adev,<br>
>> /* Get a log2 for easy divisions. */<br>
>> adev->mm_stats.log2_max_MBps = ilog2(max(1u, max_MBps));<br>
>> - amdgpu_fbdev_init(adev);<br>
>> -<br>
>> r = amdgpu_ib_pool_init(adev);<br>
>> if (r) {<br>
>> dev_err(adev->dev, "IB initialization failed (%d).\n", r);<br>
>> goto failed;<br>
>> }<br>
>> + amdgpu_fbdev_init(adev);<br>
>> +<br>
> <br>
> As noted internally as well, please more that one more further down<br>
> behind the call to amdgpu_ib_ring_tests().<br>
<br>
If I understand correctly, that could result in no console output in the<br>
worst case if there's trouble with the ring & IB tests? That doesn't<br>
seem very good.<br>
<br>
<br>
-- <br>
Earthling Michel Dänzer | <a href="http://www.amd.com">
http://www.amd.com</a><br>
Libre software enthusiast | Mesa and X developer<br>
</div>
</span></font>
</body>
</html>