<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> <style type="text/css" style="display:none;"></style> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr"> <p>that's because some customer modified QEMU and trap each VF's memory access, which cost too much time if using CPU access FB,</p> <p><br> </p> <p>emmm, I guess we have no better choice by far, do as you suggested, </p> <p><br> </p> <p>to kill risk the negative effect that we may have no console if ib test failed, I suggest we don't block driver proceeding after ib test failure detected , doable ?<br> </p> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>发件人:</b> Christian König <deathsimple@vodafone.de><br> <b>发送时间:</b> 2017年2月8日 23:59:10<br> <b>收件人:</b> Liu, Monk; Michel Dänzer<br> <b>抄送:</b> amd-gfx@lists.freedesktop.org<br> <b>主题:</b> Re: 答复: 答复: [PATCH] drm/amdgpu:fix amdgpu_sa_bo_new error</font> <div> </div> </div> <div> <div class="moz-cite-prefix">Am 08.02.2017 um 16:53 schrieb Liu, Monk:<br> </div> <blockquote cite="mid:DM5PR12MB1610D9A7A6D35390193ED57D84420@DM5PR12MB1610.namprd12.prod.outlook.com" type="cite"> <meta name="Generator" content="Microsoft Exchange Server"> <style></style> <meta content="text/html; charset=UTF-8"> <style type="text/css" style="">  </style> <div dir="ltr"> <div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Arial,Helvetica,sans-serif"> <p>agreed, why not just use cpu to clear it ? is it because performance ?<br> </p> </div> </div> </blockquote> <br> Pixel Ding removed the CPU clear because "There's a failure caused by this is that handshaking gets timeout of SRIOV virtual function."<br> <br> I can only assume that this is really adding to much delay at bootup.<br> <br> <blockquote cite="mid:DM5PR12MB1610D9A7A6D35390193ED57D84420@DM5PR12MB1610.namprd12.prod.outlook.com" type="cite"> <div dir="ltr"> <div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Arial,Helvetica,sans-serif"> <p></p> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" color="#000000" face="Calibri, sans-serif"><b>发件人:</b> Michel Dänzer <a class="moz-txt-link-rfc2396E" href="mailto:michel@daenzer.net"><michel@daenzer.net></a><br> <b>发送时间:</b> 2017年2月8日 23:52:02<br> <b>收件人:</b> Christian König; Liu, Monk<br> <b>抄送:</b> <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org"> amd-gfx@lists.freedesktop.org</a><br> <b>主题:</b> Re: 答复: [PATCH] drm/amdgpu:fix amdgpu_sa_bo_new error</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">On 09/02/17 12:30 AM, Christian König wrote:<br> > The IB test make the decision if the hardware is working or not.<br> > <br> > So they should be the first commands (except for the ring tests) we send<br> > to the hardware.<br> > <br> > When we allocate the fb before the test we send the clear command to the<br> > hardware without knowing if the hardware really works or not.<br> > <br> > Not a big issue, but I think the order makes more sense that way.<br> <br> I just wonder if it's worth all the trouble, just to clear the fbcon<br> buffer[0], if the result is that the console output is delayed, possibly<br> indefinitely.<br> </div> </span></font></blockquote> <br> Actually that change is quite beneficial because the IB tests where usually revealing any problem.<br> <br> Not 100% sure, but when we initialize the fb later that might actually allow us to better track such problems down.<br> <br> Going to check that,<br> Christian.<br> <br> <blockquote cite="mid:DM5PR12MB1610D9A7A6D35390193ED57D84420@DM5PR12MB1610.namprd12.prod.outlook.com" type="cite"> <font size="2"><span style="font-size:10pt;"> <div class="PlainText"><br> [0] We don't have any other hardware acceleration for fbcon, so its BO<br> is only accessed by the CPU and display hardware after this, and has to<br> be pinned in the CPU visible area of VRAM at all times anyway.<br> <br> <br> -- <br> Earthling Michel Dänzer | <a moz-do-not-send="true" href="http://www.amd.com"> http://www.amd.com</a><br> Libre software enthusiast | Mesa and X developer<br> </div> </span></font></blockquote> <p><br> </p> </div> </body> </html>