<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr"> <div> <div><br> </div> <div> <p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">Patch was Tested-by and Reviewed-by: Rex Zhu <Rex.Zhu@amd.com><span style="color: rgb(255, 255, 255); font-size: 13.3333px; background-color: rgb(216, 35, 0);"></span></p> <p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;"><br> </p> <p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">Best Regards</p> <p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">Rex</p> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Alex Deucher <alexdeucher@gmail.com><br> <b>Sent:</b> Tuesday, April 11, 2017 1:02:02 AM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Deucher, Alexander<br> <b>Subject:</b> [PATCH] drm/amdgpu/gfx8: move MEC doorbell range setting</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">It's global, not queue specific, so move it out of the<br> kiq register init function.<br> <br> Signed-off-by: Alex Deucher <alexander.deucher@amd.com><br> ---<br> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 26 ++++++++++++--------------<br> 1 file changed, 12 insertions(+), 14 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c<br> index d3633cb..9bff7a9 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c<br> @@ -4930,20 +4930,6 @@ static int gfx_v8_0_kiq_init_register(struct amdgpu_ring *ring)<br> WREG32(mmCP_HQD_PQ_WPTR_POLL_ADDR, mqd->cp_hqd_pq_wptr_poll_addr_lo);<br> WREG32(mmCP_HQD_PQ_WPTR_POLL_ADDR_HI, mqd->cp_hqd_pq_wptr_poll_addr_hi);<br> <br> - /* enable the doorbell if requested */<br> - if (ring->use_doorbell) {<br> - if ((adev->asic_type == CHIP_CARRIZO) ||<br> - (adev->asic_type == CHIP_FIJI) ||<br> - (adev->asic_type == CHIP_STONEY) ||<br> - (adev->asic_type == CHIP_POLARIS10) ||<br> - (adev->asic_type == CHIP_POLARIS11) ||<br> - (adev->asic_type == CHIP_POLARIS12)) {<br> - WREG32(mmCP_MEC_DOORBELL_RANGE_LOWER,<br> - AMDGPU_DOORBELL_KIQ << 2);<br> - WREG32(mmCP_MEC_DOORBELL_RANGE_UPPER,<br> - AMDGPU_DOORBELL_MEC_RING7 << 2);<br> - }<br> - }<br> WREG32(mmCP_HQD_PQ_DOORBELL_CONTROL, mqd->cp_hqd_pq_doorbell_control);<br> <br> /* reset read and write pointers, similar to CP_RB0_WPTR/_RPTR */<br> @@ -5070,6 +5056,18 @@ static int gfx_v8_0_kiq_resume(struct amdgpu_device *adev)<br> goto done;<br> }<br> <br> + if ((adev->asic_type == CHIP_CARRIZO) ||<br> + (adev->asic_type == CHIP_FIJI) ||<br> + (adev->asic_type == CHIP_STONEY) ||<br> + (adev->asic_type == CHIP_POLARIS10) ||<br> + (adev->asic_type == CHIP_POLARIS11) ||<br> + (adev->asic_type == CHIP_POLARIS12)) {<br> + WREG32(mmCP_MEC_DOORBELL_RANGE_LOWER,<br> + AMDGPU_DOORBELL_KIQ << 2);<br> + WREG32(mmCP_MEC_DOORBELL_RANGE_UPPER,<br> + AMDGPU_DOORBELL_MEC_RING7 << 2);<br> + }<br> +<br> r = gfx_v8_0_kiq_kcq_enable(adev);<br> if (r)<br> goto done;<br> -- <br> 2.5.5<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk719840" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <div id="LPBorder_GT_14918465006200.5341002836357802" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;"> <table id="LPContainer_14918465006170.8145173422526568" cellspacing="0" style="width: 90%; position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top-width: 1px; border-top-style: dotted; border-top-color: rgb(200, 200, 200); border-bottom-width: 1px; border-bottom-style: dotted; border-bottom-color: rgb(200, 200, 200); background-color: rgb(255, 255, 255);"> <tbody> <tr valign="top" style="border-spacing: 0px;"> <td id="TextCell_14918465006180.8883486734703183" colspan="2" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;"> <div id="LPRemovePreviewContainer_14918465006180.9254352936986834"></div> <div id="LPTitle_14918465006180.7526611653156579" style="top: 0px; color: rgb(0, 120, 215); font-weight: normal; font-size: 21px; font-family: wf_segoe-ui_light, 'Segoe UI Light', 'Segoe WP Light', 'Segoe UI', 'Segoe WP', Tahoma, Arial, sans-serif; line-height: 21px;"> <a id="LPUrlAnchor_14918465006180.6247792565263808" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank" style="text-decoration: none;">amd-gfx Info Page - lists.freedesktop.org</a></div> <div id="LPMetadata_14918465006180.8303352994844317" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, 'Segoe UI', 'Segoe WP', Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;"> lists.freedesktop.org</div> <div id="LPDescription_14918465006200.8823355177883059" style="display: block; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, 'Segoe UI', 'Segoe WP', Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;"> To see the collection of prior postings to the list, visit the amd-gfx Archives. Using amd-gfx: To post a message to all the list members, send email ...</div> </td> </tr> </tbody> </table> </div> <br> <br> </div> </span></font></div> </body> </html>