<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr"> <p><span style="font-size: 10pt;">On 28/04/17 11:12 PM, Xie, AlexBin wrote:</span><br> </p> <div style="color: rgb(0, 0, 0);"><font size="2"><span style="font-size:10pt;"> <div class="PlainText">>> Am 28.04.2017 um 10:47 schrieb Michel Dänzer:<br> >>> From: Michel Dänzer <michel.daenzer@amd.com><br> >>><br> >>> Some of these paths probably cannot be interrupted by a signal anyway.<br> >>> Those that can would fail to clean up things if they actually got<br> >>> interrupted.<br> >>><br> >>> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com><br> >> <br> >> Reviewed-by: Christian König <christian.koenig@amd.com><br> > <br> > Alex X: Just a reminder: amdgpu_unpin_work_func is called by work queue.<br> > Signal is blocked already. un-interruptible waiting might slow thing<br> > down very slightly.<br> <br> How so?<br> <br> Alex X: I said "might". If you think it is not slower, it is fine for me.</div> <div class="PlainText">My real concern is that the signals are blocked for work queue already. We don't need this change to avoid unnecessary risk.</div> <div class="PlainText">In theory, I am not against this change.</div> <div class="PlainText"><br> -- <br> Earthling Michel Dänzer | <a href="http://www.amd.com" id="LPlnk108541" previewremoved="true"> http://www.amd.com</a><br> Libre software enthusiast | Mesa and X developer<br> </div> </span></font></div> </div> </body> </html>