<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr"> <p>I just realised that there are some stress test that sends huge amount of signals. I used those tests in the pass 2 years...</p> <p><br> </p> <p><span style="font-size: 12pt;">-Alex Bin</span><br> </p> <div style="color: rgb(0, 0, 0);"> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Christian König <deathsimple@vodafone.de><br> <b>Sent:</b> Monday, May 1, 2017 10:28 AM<br> <b>To:</b> Xie, AlexBin; Michel Dänzer<br> <b>Cc:</b> amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH] drm/amdgpu: Make amdgpu_bo_reserve use uninterruptible waits for cleanup</font> <div> </div> </div> <div> <div class="moz-cite-prefix">Am 01.05.2017 um 02:13 schrieb Xie, AlexBin:<br> </div> <blockquote type="cite"> <div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Arial,Helvetica,sans-serif"> <p><span style="font-size:10pt">On 28/04/17 11:12 PM, Xie, AlexBin wrote:</span><br> </p> <div style="color:rgb(0,0,0)"><font size="2"><span style="font-size:10pt"> <div class="PlainText">>> Am 28.04.2017 um 10:47 schrieb Michel Dänzer:<br> >>> From: Michel Dänzer <a class="moz-txt-link-rfc2396E" href="mailto:michel.daenzer@amd.com"> <michel.daenzer@amd.com></a><br> >>><br> >>> Some of these paths probably cannot be interrupted by a signal anyway.<br> >>> Those that can would fail to clean up things if they actually got<br> >>> interrupted.<br> >>><br> >>> Signed-off-by: Michel Dänzer <a class="moz-txt-link-rfc2396E" href="mailto:michel.daenzer@amd.com"> <michel.daenzer@amd.com></a><br> >> <br> >> Reviewed-by: Christian König <a class="moz-txt-link-rfc2396E" href="mailto:christian.koenig@amd.com"> <christian.koenig@amd.com></a><br> > <br> > Alex X: Just a reminder: amdgpu_unpin_work_func is called by work queue.<br> > Signal is blocked already. un-interruptible waiting might slow thing<br> > down very slightly.<br> <br> How so?<br> <br> Alex X: I said "might". If you think it is not slower, it is fine for me.</div> <div class="PlainText">My real concern is that the signals are blocked for work queue already. We don't need this change to avoid unnecessary risk.</div> <div class="PlainText">In theory, I am not against this change.</div> </span></font></div> </div> </blockquote> <br> I have to agree with that. For waits from work queues it is usually best to implicitly use un-interruptible waits for documentation purposes.<br> <br> In other words even when we are sure that the code can't receive a signal we should write it conservatively.<br> <br> Christian.<br> <br> <blockquote type="cite"> <div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Arial,Helvetica,sans-serif"> <div style="color:rgb(0,0,0)"><font size="2"><span style="font-size:10pt"> <div class="PlainText"><br> -- <br> Earthling Michel Dänzer | <a href="http://www.amd.com" id="LPlnk108541" previewremoved="true"> http://www.amd.com</a><br> Libre software enthusiast | Mesa and X developer<br> </div> </span></font></div> </div> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <br> <pre>_______________________________________________ amd-gfx mailing list <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> </pre> </blockquote> <p><br> </p> </div> </div> </div> </body> </html>