<div dir="auto"><div>Hi, Alex<div dir="auto"><br></div><div dir="auto">Shouldn't the function return true when the refresh rate > 120? If so, same comment on patch 2.</div><div dir="auto"><br></div><div dir="auto">BR</div><div dir="auto">Nils</div><br><div class="gmail_extra"><br><div class="gmail_quote">Den 11 maj 2017 7:59 em skrev "Alex Deucher" <<a href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>>:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Even if the vblank period would allow it, it still seems to<br>
be problematic on some cards.<br>
<br>
bug: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=96868" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/<wbr>show_bug.cgi?id=96868</a><br>
<br>
Signed-off-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>><br>
---<br>
 drivers/gpu/drm/amd/amdgpu/ci_<wbr>dpm.c | 6 ++++++<br>
 1 file changed, 6 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/<wbr>ci_dpm.c b/drivers/gpu/drm/amd/amdgpu/<wbr>ci_dpm.c<br>
index 6dc1410..eb5d03b 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/<wbr>ci_dpm.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/<wbr>ci_dpm.c<br>
@@ -906,6 +906,12 @@ static bool ci_dpm_vblank_too_short(struct amdgpu_device *adev)<br>
        u32 vblank_time = amdgpu_dpm_get_vblank_time(<wbr>adev);<br>
        u32 switch_limit = adev->mc.vram_type == AMDGPU_VRAM_TYPE_GDDR5 ? 450 : 300;<br>
<br>
+       /* disable mclk switching if the refresh is >120Hz, even if the<br>
+        * blanking period would allow it<br>
+        */<br>
+       if (amdgpu_dpm_get_vrefresh(adev) > 120)<br>
+               return false;<br>
+<br>
        if (vblank_time < switch_limit)<br>
                return true;<br>
        else<br>
<font color="#888888">--<br>
2.5.5<br>
<br>
______________________________<wbr>_________________<br>
amd-gfx mailing list<br>
<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/amd-gfx</a><br>
</font></blockquote></div><br></div></div></div>