<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=gb2312">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<div>Reviewed-by: Chunming Zhou <br>
<br>
<br>
<br>
-------- 原始邮件 --------<br>
主题：Re: [PATCH] drm/amdgpu: fix ocl test performance drop<br>
发件人：Flora Cui <br>
收件人："Zhou, David(ChunMing)" <br>
抄送：amd-gfx@lists.freedesktop.org<br>
<br>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">partial revert commit <6971d3d> - drm/amdgpu: cleanup logic in<br>
amdgpu_vm_flush<br>
<br>
Change-Id: Iadce9d613dfe9a739643a74050cea55854832adb<br>
Signed-off-by: Flora Cui <Flora.Cui@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 +--<br>
1 file changed, 1 insertion(+), 2 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c<br>
index 4573d8c..5b9a73d 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c<br>
@@ -743,8 +743,7 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job)<br>
id->gws_size != job->gws_size ||<br>
id->oa_base != job->oa_base ||<br>
id->oa_size != job->oa_size);<br>
- bool vm_flush_needed = job->vm_needs_flush ||<br>
- amdgpu_vm_ring_has_compute_vm_bug(ring);<br>
+ bool vm_flush_needed = job->vm_needs_flush;<br>
unsigned patch_offset = 0;<br>
int r;<br>
<br>
-- <br>
2.7.4<br>
<br>
On Mon, May 22, 2017 at 04:58:00PM +0800, zhoucm1 wrote:<br>
> <br>
> <br>
> On 2017年05月22日 16:34, Flora Cui wrote:<br>
> >partial revert commit <6971d3d> - drm/amdgpu: cleanup logic in<br>
> >amdgpu_vm_flush<br>
> ><br>
> >Change-Id: Iadce9d613dfe9a739643a74050cea55854832adb<br>
> >Signed-off-by: Flora Cui <Flora.Cui@amd.com><br>
> >---<br>
> > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 +++---<br>
> > 1 file changed, 3 insertions(+), 3 deletions(-)<br>
> ><br>
> >diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c<br>
> >index 4573d8c..11d58f7 100644<br>
> >--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c<br>
> >+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c<br>
> >@@ -743,8 +743,7 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job)<br>
> > id->gws_size != job->gws_size ||<br>
> > id->oa_base != job->oa_base ||<br>
> > id->oa_size != job->oa_size);<br>
> >- bool vm_flush_needed = job->vm_needs_flush ||<br>
> >- amdgpu_vm_ring_has_compute_vm_bug(ring);<br>
> >+ bool vm_flush_needed = job->vm_needs_flush;<br>
> > unsigned patch_offset = 0;<br>
> > int r;<br>
> >@@ -753,7 +752,8 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job)<br>
> > vm_flush_needed = true;<br>
> > }<br>
> >- if (!vm_flush_needed && !gds_switch_needed)<br>
> >+ if (!vm_flush_needed && !gds_switch_needed &&<br>
> >+ !amdgpu_vm_ring_has_compute_vm_bug(ring))<br>
> > return 0;<br>
> here change isn't needed.<br>
> <br>
> Regards,<br>
> David Zhou<br>
> > if (ring->funcs->init_cond_exec)<br>
> <br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font>
</body>
</html>