<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> <meta name="Generator" content="Microsoft Exchange Server"> <style></style> </head> <body> <meta content="text/html; charset=UTF-8"> <style type="text/css" style="">  </style> <div dir="ltr"> <div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Arial,Helvetica,sans-serif"> <p>Patches has been applied.</p> <p><br> </p> <p>Thanks.</p> <p><br> </p> <p>Best Regards</p> <p>Rex<br> </p> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Huang, JinHuiEric<br> <b>Sent:</b> Friday, May 19, 2017 12:28:09 AM<br> <b>To:</b> Dan Carpenter; Deucher, Alexander; Zhu, Rex<br> <b>Cc:</b> Koenig, Christian; David Airlie; Wang, Ken; Huang, Ray; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; kernel-janitors@vger.kernel.org<br> <b>Subject:</b> Re: [PATCH] drm/amd/powerplay: fix a signedness bugs</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">Reviewed-by: Eric Huang <JinHuiEric.Huang@amd.com><br> <br> <br> On 2017-05-16 10:42 AM, Dan Carpenter wrote:<br> > Smatch complains about a signedness bug here:<br> ><br> > vega10_hwmgr.c:4202 vega10_force_clock_level()<br> > warn: always true condition '(i >= 0) => (0-u32max >= 0)'<br> ><br> > Fixes: 7b52db39a4c2 ("drm/amd/powerplay: fix bug sclk/mclk level can't be set on vega10.")<br> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com><br> ><br> > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br> > index ad30f5d3a10d..2614af2f553f 100644<br> > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br> > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br> > @@ -4186,7 +4186,7 @@ static int vega10_force_clock_level(struct pp_hwmgr *hwmgr,<br> > enum pp_clock_type type, uint32_t mask)<br> > {<br> > struct vega10_hwmgr *data = (struct vega10_hwmgr *)(hwmgr->backend);<br> > - uint32_t i;<br> > + int i;<br> > <br> > if (hwmgr->dpm_level != AMD_DPM_FORCED_LEVEL_MANUAL)<br> > return -EINVAL;<br> <br> </div> </span></font> </body> </html>