<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Arial,Helvetica,sans-serif">
<p><font size="2"><span style="font-size:10pt">>>s/diable/disable/<br>
<br>
>>Also, why not make "Failed" lower-case at the same time?</span></font></p>
<p><br>
</p>
<p>Of course. thanks.</p>
<p><br>
</p>
<p>Best Regards</p>
<p>Rex<br>
</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of William Lewis <minutemaidpark@hotmail.com><br>
<b>Sent:</b> Thursday, June 8, 2017 8:47:58 PM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Subject:</b> Re: [PATCH] drm/amd/powerplay: fix copy error in powerplay.</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText"><br>
<br>
On 06/08/2017 02:50 AM, Rex Zhu wrote:<br>
> should disable led dpm feature when stop dpm.<br>
><br>
> Change-Id: I9d78459ff2467d2eba0b26d9696138f7eba484a0<br>
> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 +++---<br>
> 1 file changed, 3 insertions(+), 3 deletions(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br>
> index 9338aca..b6df00c 100644<br>
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br>
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br>
> @@ -2702,9 +2702,9 @@ static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap)<br>
> <br>
> if(data->smu_features[GNLD_LED_DISPLAY].supported == true){<br>
> PP_ASSERT_WITH_CODE(!vega10_enable_smc_features(hwmgr->smumgr,<br>
> - true, data->smu_features[GNLD_LED_DISPLAY].smu_feature_bitmap),<br>
> - "Attempt to Enable LED DPM feature Failed!", return -EINVAL);<br>
> - data->smu_features[GNLD_LED_DISPLAY].enabled = true;<br>
> + false, data->smu_features[GNLD_LED_DISPLAY].smu_feature_bitmap),<br>
> + "Attempt to diable LED DPM feature Failed!", return -EINVAL);<br>
<br>
s/diable/disable/<br>
<br>
Also, why not make "Failed" lower-case at the same time?<br>
<br>
> + data->smu_features[GNLD_LED_DISPLAY].enabled = false;<br>
> }<br>
> <br>
> for (i = 0; i < GNLD_DPM_MAX; i++) {<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font>
</body>
</html>