<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 14 (filtered medium)"> <style>  </style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black; background-color:white"> OK.<br> <br> </div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black; background-color:white"> Regards,<br> </div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black; background-color:white"> Shirish S<br> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Deucher, Alexander<br> <b>Sent:</b> Friday, June 9, 2017 6:23:12 PM<br> <b>To:</b> S, Shirish; amd-gfx@lists.freedesktop.org; Alex Deucher<br> <b>Subject:</b> RE: [PATCH 2/2] drm/amdgpu/gfx: spread queues across pipes again for 1 MEC parts</font> <div> </div> </div> <div> <div class="WordSection1"> <p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:#1F497D">Please include patch 1 of this series as well.</span></p> <p class="MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:#1F497D"> </span></p> <div style="border:none; border-left:solid blue 1.5pt; padding:0in 0in 0in 4.0pt"> <div> <div style="border:none; border-top:solid #B5C4DF 1.0pt; padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif""> S, Shirish <br> <b>Sent:</b> Friday, June 09, 2017 8:53 AM<br> <b>To:</b> amd-gfx@lists.freedesktop.org; Alex Deucher<br> <b>Cc:</b> Deucher, Alexander<br> <b>Subject:</b> Re: [PATCH 2/2] drm/amdgpu/gfx: spread queues across pipes again for 1 MEC parts</span></p> </div> </div> <p class="MsoNormal"> </p> <div> <div> <p class="MsoNormal" style="background:white"><span style="font-size:11.0pt; font-family:"Arial","sans-serif"; color:black">Sure Alex.</span></p> </div> <div> <p class="MsoNormal" style="background:white"><span style="font-size:11.0pt; font-family:"Arial","sans-serif"; color:black">I shall update the result on stoney soon.</span></p> </div> <div> <p class="MsoNormal" style="background:white"><span style="font-size:11.0pt; font-family:"Arial","sans-serif"; color:black">Regards,</span></p> </div> <div> <p class="MsoNormal" style="background:white"><span style="font-size:11.0pt; font-family:"Arial","sans-serif"; color:black">Shirish S</span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="x_divRplyFwdMsg"> <p class="MsoNormal"><b><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:black">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:black"> Alex Deucher <<a href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>><br> <b>Sent:</b> Friday, June 9, 2017 6:19:30 PM<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <b>Cc:</b> Deucher, Alexander; S, Shirish<br> <b>Subject:</b> [PATCH 2/2] drm/amdgpu/gfx: spread queues across pipes again for 1 MEC parts</span></p> <div> <p class="MsoNormal"> </p> </div> </div> </div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:10.0pt">Now that interrupts are properly enabled for all pipes, this<br> should be function properly.<br> <br> Cc: Shirish S <<a href="mailto:shirish.s@amd.com">shirish.s@amd.com</a>><br> Signed-off-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>><br> ---<br> <br> Shirish,<br> <br> Can you test this change on your Stoney setup?<br> <br> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 12 +++---------<br> 1 file changed, 3 insertions(+), 9 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c<br> index dfbf027..03c23e3 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c<br> @@ -125,15 +125,9 @@ void amdgpu_gfx_compute_queue_acquire(struct amdgpu_device *adev)<br> if (mec >= adev->gfx.mec.num_mec)<br> break;<br> <br> - if (adev->gfx.mec.num_mec > 1) {<br> - /* policy: amdgpu owns the first two queues of the first MEC */<br> - if (mec == 0 && queue < 2)<br> - set_bit(i, adev->gfx.mec.queue_bitmap);<br> - } else {<br> - /* policy: amdgpu owns all queues in the first pipe */<br> - if (mec == 0 && pipe == 0)<br> - set_bit(i, adev->gfx.mec.queue_bitmap);<br> - }<br> + /* policy: amdgpu owns the first two queues of the first MEC */<br> + if (mec == 0 && queue < 2)<br> + set_bit(i, adev->gfx.mec.queue_bitmap);<br> }<br> <br> /* update the number of active compute rings */<br> -- <br> 2.5.5</span></p> </div> </div> </div> </div> </body> </html>