<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html;
      charset=windows-1252">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">Hi Alex,<br>
      <br>
      yeah, the change looks totally ok to me. The problem is just that
      I'm not familiar with that part of the source.<br>
      <br>
      Marek came up with that, so he should at least take a look and
      nod.<br>
      <br>
      Regards,<br>
      Christian.<br>
      <br>
      Am 22.06.2017 um 17:33 schrieb Xie, AlexBin:<br>
    </div>
    <blockquote type="cite"
cite="mid:DM5PR12MB1257B1FCC981D29A6D4045CDF2DB0@DM5PR12MB1257.namprd12.prod.outlook.com">
      <meta http-equiv="Content-Type" content="text/html;
        charset=windows-1252">
      <style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
      <div id="divtagdefaultwrapper"
style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;"
        dir="ltr">
        <p>Hi Christian,</p>
        <p><br>
        </p>
        <p>In fact, the change from spinlock to atomic is quite painful.
          When I started, I thought it was easy but later I found there
          might be race condition here and there. Now I think the change
          looks more robust. In kernel source, there are several other
          drivers used the same trick.</p>
        <p><br>
        </p>
        <p>On the other hand, I think the logic itself might be
          optimized considering the locking. But I had spent quite some
          effort to maintain original logic.<br>
        </p>
        <p><br>
        </p>
        <p>Thanks,</p>
        <p>Alex Bin<br>
        </p>
        <p><br>
        </p>
        <div style="color: rgb(0, 0, 0);">
          <div>
            <div id="x_divRplyFwdMsg" dir="ltr"><font
                style="font-size:11pt" face="Calibri, sans-serif"
                color="#000000"><b>From:</b> Christian König
                <a class="moz-txt-link-rfc2396E" href="mailto:deathsimple@vodafone.de"><deathsimple@vodafone.de></a><br>
                <b>Sent:</b> Thursday, June 22, 2017 3:35 AM<br>
                <b>To:</b> Xie, AlexBin; <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br>
                <b>Subject:</b> Re: [PATCH 1/3] drm/amdgpu: fix a typo</font>
              <div> </div>
            </div>
          </div>
          <font size="2"><span style="font-size:10pt;">
              <div class="PlainText">Am 22.06.2017 um 04:42 schrieb Alex
                Xie:<br>
                > Signed-off-by: Alex Xie <a class="moz-txt-link-rfc2396E" href="mailto:AlexBin.Xie@amd.com"><AlexBin.Xie@amd.com></a><br>
                <br>
                With the commit message fixed as Michel suggested
                patches #1 and #2 are <br>
                Reviewed-by: Christian König
                <a class="moz-txt-link-rfc2396E" href="mailto:christian.koenig@amd.com"><christian.koenig@amd.com></a> as well.<br>
                <br>
                On patch #3 Marek needs to take a look, cause I don't
                know the logic <br>
                behind that.<br>
                <br>
                Regards,<br>
                Christian.<br>
                <br>
                > ---<br>
                >   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-<br>
                >   1 file changed, 1 insertion(+), 1 deletion(-)<br>
                ><br>
                > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
                b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c<br>
                > index 7635f38..94c27fc 100644<br>
                > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c<br>
                > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c<br>
                > @@ -494,7 +494,7 @@ static int
                amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,<br>
                >                                
                &e->user_invalidated) &&
                e->user_pages) {<br>
                >   <br>
                >                                /* We acquired a
                page array, but somebody<br>
                > -                              * invalidated it.
                Free it an try again<br>
                > +                              * invalidated it.
                Free it and try again<br>
                >                                 */<br>
                >                               
                release_pages(e->user_pages,<br>
                >                                             
                e->robj->tbo.ttm->num_pages,<br>
                <br>
                <br>
              </div>
            </span></font></div>
      </div>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
amd-gfx mailing list
<a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
</pre>
    </blockquote>
    <p><br>
    </p>
  </body>
</html>