<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Christian,<br>
<br>
<div class="moz-cite-prefix">On Saturday 15 July 2017 07:17 PM,
Christian König wrote:<br>
</div>
<blockquote
cite="mid:94559aac-60b7-d2f9-7594-89e939980dd5@vodafone.de"
type="cite">Am 15.07.2017 um 09:12 schrieb Arvind Yadav:
<br>
<blockquote type="cite">pci_device_id are not supposed to change
at runtime. All functions
<br>
working with pci_device_id provided by <linux/pci.h> work
with
<br>
const pci_device_id. So mark the non-const structs as const.
<br>
<br>
File size before:
<br>
text data bss dec hex filename
<br>
6560 23212 72 29844 7494
gpu/drm/radeon/radeon_drv.o
<br>
<br>
File size After adding 'const':
<br>
text data bss dec hex filename
<br>
28960 812 72 29844 7494
gpu/drm/radeon/radeon_drv.o
<br>
<br>
Signed-off-by: Arvind Yadav <a class="moz-txt-link-rfc2396E" href="mailto:arvind.yadav.cs@gmail.com"><arvind.yadav.cs@gmail.com></a>
<br>
</blockquote>
<br>
Impressive result for such a simple change.
<br>
<br>
Patch is Reviewed-by: Christian König
<a class="moz-txt-link-rfc2396E" href="mailto:christian.koenig@amd.com"><christian.koenig@amd.com></a>
<br>
<br>
Are the PCI IDs already const in amdgpu or do we need a similar
patch there as well? I only see patch 1 of 5 in my inbox.
<br>
</blockquote>
I have send all gpu patch to
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<span style="color: rgb(51, 51, 51); font-family: "normal
arial", sans-serif; font-size: 16px; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans: 2;
text-align: start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color: rgb(255, 255,
255); text-decoration-style: initial; text-decoration-color:
initial; display: inline !important; float: none;">David Airlie</span>.
Please check with him.<span style="color: rgb(51, 51, 51);
font-family: "normal arial", sans-serif; font-size:
16px; font-style: normal; font-variant-ligatures: normal;
font-variant-caps: normal; font-weight: normal; letter-spacing:
normal; orphans: 2; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-color: rgb(255, 255, 255); text-decoration-style:
initial; text-decoration-color: initial; display: inline
!important; float: none;"><br>
</span>
<blockquote
cite="mid:94559aac-60b7-d2f9-7594-89e939980dd5@vodafone.de"
type="cite">
<br>
Christian.
<br>
<br>
<blockquote type="cite">---
<br>
drivers/gpu/drm/radeon/radeon_drv.c | 2 +-
<br>
1 file changed, 1 insertion(+), 1 deletion(-)
<br>
<br>
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
b/drivers/gpu/drm/radeon/radeon_drv.c
<br>
index e25cb51..b079937 100644
<br>
--- a/drivers/gpu/drm/radeon/radeon_drv.c
<br>
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
<br>
@@ -298,7 +298,7 @@ module_param_named(uvd, radeon_uvd, int,
0444);
<br>
MODULE_PARM_DESC(vce, "vce enable/disable vce support (1 =
enable, 0 = disable)");
<br>
module_param_named(vce, radeon_vce, int, 0444);
<br>
-static struct pci_device_id pciidlist[] = {
<br>
+static const struct pci_device_id pciidlist[] = {
<br>
radeon_PCI_IDS
<br>
};
<br>
</blockquote>
<br>
<br>
<br>
</blockquote>
Regards,<br>
~arvind<br>
</body>
</html>