<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p>Hi Alex,</p> <p><br> </p> <p>See below comment about coding style of 80 characters per line.</p> <p><br> </p> <p>Thanks,</p> <p>Alex Bin Xie<br> </p> <div style="color: rgb(0, 0, 0);"> <div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" color="#000000" face="Calibri, sans-serif"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Alex Deucher <alexdeucher@gmail.com><br> <b>Sent:</b> Tuesday, August 22, 2017 4:49 PM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Deucher, Alexander<br> <b>Subject:</b> [PATCH] drm/amdgpu: set sched_hw_submission higher for KIQ</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">KIQ doesn't really use the GPU scheduler. The base<br> drivers generally use the KIQ ring directly rather than<br> submitting IBs. However, amdgpu_sched_hw_submission<br> (which defaults to 2) limits the number of outstanding<br> fences to 2. KFD uses the KIQ for TLB flushes and the<br> 2 fence limit hurts performance when there are several KFD<br> processes running.<br> <br> Signed-off-by: Alex Deucher <alexander.deucher@amd.com><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 14 ++++++++++++--<br> 1 file changed, 12 insertions(+), 2 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c<br> index 6c5646b..f39b851 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c<br> @@ -170,6 +170,16 @@ int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring,<br> unsigned irq_type)<br> {<br> int r;<br> + int sched_hw_submission = amdgpu_sched_hw_submission;<br> +<br> + /* Set the hw submission limit higher for KIQ because<br> + * it's used for a number of gfx/compute tasks by both<br> + * KFD and KGD which may have outstanding fences and<br> + * it doesn't really use the gpu scheduler anyway;<br> + * KIQ tasks get submitted directly to the ring.<br> + */<br> + if (ring->funcs->type == AMDGPU_RING_TYPE_KIQ)<br> + sched_hw_submission *= 2;<br> <br> if (ring->adev == NULL) {<br> if (adev->num_rings >= AMDGPU_MAX_RINGS)<br> @@ -179,7 +189,7 @@ int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring,<br> ring->idx = adev->num_rings++;<br> adev->rings[ring->idx] = ring;<br> r = amdgpu_fence_driver_init_ring(ring,<br> - amdgpu_sched_hw_submission);<br> + sched_hw_submission);<br> <br> <font size="2"><span style="font-size:10pt;">Alex Bin Xie: With shorter variable name, there is no need to wrap into a new line of code.<br> </span></font><br> if (r)<br> return r;<br> }<br> @@ -219,7 +229,7 @@ int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring,<br> }<br> <br> ring->ring_size = roundup_pow_of_two(max_dw * 4 *<br> - amdgpu_sched_hw_submission);<br> + sched_hw_submission);<br> <br> Alex Bin Xie: With shorter variable name, there is no need to wrap into a new line of code.<br> <br> <br> ring->buf_mask = (ring->ring_size / 4) - 1;<br> ring->ptr_mask = ring->funcs->support_64bit_ptrs ?<br> -- <br> 2.5.5<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk481298" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <div id="LPBorder_GT_15034355097780.9476790803108427" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;"> <table id="LPContainer_15034355097620.3351801972752181" style="width: 90%; background-color: rgb(255, 255, 255); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200);" role="presentation" cellspacing="0"> <tbody> <tr style="border-spacing: 0px;" valign="top"> <td id="TextCell_15034355097660.9624564304984162" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;" colspan="2"> <div id="LPRemovePreviewContainer_15034355097670.35788918500388844"></div> <div id="LPTitle_15034355097670.9951158056658015" style="top: 0px; color: rgb(0, 120, 215); font-weight: 400; font-size: 21px; font-family: "wf_segoe-ui_light","Segoe UI Light","Segoe WP Light","Segoe UI","Segoe WP",Tahoma,Arial,sans-serif; line-height: 21px;"> <a id="LPUrlAnchor_15034355097700.5680558664367118" style="text-decoration: none;" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank">amd-gfx Info Page - freedesktop.org</a></div> <div id="LPMetadata_15034355097720.9029902954563747" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: 400; font-family: "wf_segoe-ui_normal","Segoe UI","Segoe WP",Tahoma,Arial,sans-serif; font-size: 14px; line-height: 14px;"> lists.freedesktop.org</div> <div id="LPDescription_15034355097750.2918560230998244" style="display: block; color: rgb(102, 102, 102); font-weight: 400; font-family: "wf_segoe-ui_normal","Segoe UI","Segoe WP",Tahoma,Arial,sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;"> Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. Use of all freedesktop.org lists is subject to our Code of ...</div> </td> </tr> </tbody> </table> </div> <br> </div> </span></font></div> </div> </body> </html>