<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Exchange Server"> <style></style> </head> <body> <div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black; background-color:white"> Hi Dave, <br> <br> </div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black; background-color:white"> Agreed, those should probably be per adapter. We'll take a look and fix them up. Thanks for pointing them out.<br> <br> </div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black; background-color:white"> Regards,<br> </div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black; background-color:white"> Aric<br> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Wentland, Harry<br> <b>Sent:</b> Thursday, September 28, 2017 8:29:58 PM<br> <b>To:</b> Dave Airlie; amd-gfx mailing list; Cyr, Aric; Koo, Anthony<br> <b>Subject:</b> Re: global data in display/dc/dce/dce_abm.c</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">On 2017-09-28 08:24 PM, Dave Airlie wrote:<br> > On 29 September 2017 at 10:18, Dave Airlie <airlied@gmail.com> wrote:<br> >> Hi Harry,<br> >><br> >> stored_backlight_registers is a global static struct in bss segment,<br> >> it should probably be per device.<br> > <br> > There is also cached_wait_loop_number in<br> > amd/display/dc/dce/dce_dmcu.c<br> > <br> <br> Thanks for spotting these. We probably want to fix them up.<br> <br> I think both are used for embedded panels only which is why we haven't<br> noticed this being a problem.<br> <br> Aric, Anthony, thoughts? Can you provide a patch to fix these?<br> <br> Harry<br> <br> > Dave.<br> > <br> </div> </span></font> </body> </html>