<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p>got it, I will send another patch for reviewing.<br>
</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Alex Deucher <alexdeucher@gmail.com><br>
<b>Sent:</b> Wednesday, October 11, 2017 9:30:01 PM<br>
<b>To:</b> Wang, Ken<br>
<b>Cc:</b> amd-gfx@lists.freedesktop.org; Deucher, Alexander<br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: correct reference clock value on vega10</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">On Wed, Oct 11, 2017 at 4:48 AM, Wang, Ken <Ken.Wang@amd.com> wrote:<br>
> From: Ken Wang <Ken.Wang@amd.com><br>
><br>
> Change-Id: I377029075af1e2e002f7cfd793ddd58d8610e474<br>
> Signed-off-by: Ken Wang <Ken.Wang@amd.com><br>
<br>
NAK. We use 10khz units for all other asics. We already multiply<br>
this by 10 in amdgpu_kms.c before sending it to userspace:<br>
/* return all clocks in KHz */<br>
dev_info.gpu_counter_freq = amdgpu_asic_get_xclk(adev) * 10;<br>
<br>
Just return adev->clock.spll.reference_freq.<br>
<br>
Alex<br>
<br>
<br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/soc15.c | 6 ++----<br>
> 1 file changed, 2 insertions(+), 4 deletions(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c<br>
> b/drivers/gpu/drm/amd/amdgpu/soc15.c<br>
> index 7839677..a510c8c 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/soc15.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c<br>
> @@ -279,10 +279,8 @@ static void soc15_init_golden_registers(struct<br>
> amdgpu_device *adev)<br>
> }<br>
> static u32 soc15_get_xclk(struct amdgpu_device *adev)<br>
> {<br>
> - if (adev->asic_type == CHIP_VEGA10)<br>
> - return adev->clock.spll.reference_freq/4;<br>
> - else<br>
> - return adev->clock.spll.reference_freq;<br>
> + /* return the value in Khz instead of 10Khz*/<br>
> + return adev->clock.spll.reference_freq * 10;<br>
> }<br>
><br>
><br>
> --<br>
> 2.7.4<br>
><br>
><br>
> _______________________________________________<br>
> amd-gfx mailing list<br>
> amd-gfx@lists.freedesktop.org<br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
><br>
</div>
</span></font>
</body>
</html>