<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Harry,<br>
<br>
actually it's best practice that you only ignore ERESTARTSYS here,
see other code in the driver as well.<br>
<br>
EINTR means that the IOCTL was interrupted and can't be restarted
because of some problem.<br>
<br>
EAGAIN mean the we can't do this operation right now, but might be
able to do it at some point in the future.<br>
<br>
Both sound like a good idea to note to the user.<br>
<br>
Regards,<br>
Christian.<br>
<br>
Am 26.10.2017 um 22:16 schrieb Andrey Grodzovsky:<br>
</div>
<blockquote type="cite"
cite="mid:ff616ee9-0e16-5278-1169-b75b61db6141@amd.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 2017-10-26 04:08 PM, Harry
Wentland wrote:<br>
</div>
<blockquote
cite="mid:20171026200801.14662-1-harry.wentland@amd.com"
type="cite">
<pre wrap="">v2: Also don't print for ERESTARTSYS or EAGAIN
Signed-off-by: Harry Wentland <a class="moz-txt-link-rfc2396E" href="mailto:harry.wentland@amd.com" moz-do-not-send="true"><harry.wentland@amd.com></a></pre>
</blockquote>
<br>
<pre wrap="">Reviewed-by: Andrey Grodzovsky <a class="moz-txt-link-rfc2396E" href="mailto:alexander.deucher@amd.com" moz-do-not-send="true"><andrey.grodzovsky@amd.com></a></pre>
<br>
Thanks,<br>
Andrey<br>
<br>
<blockquote
cite="mid:20171026200801.14662-1-harry.wentland@amd.com"
type="cite">
<pre wrap="">---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index cf15701f208d..4401f0fb3f02 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -2944,7 +2944,8 @@ static int dm_plane_helper_prepare_fb(struct drm_plane *plane,
amdgpu_bo_unreserve(rbo);
if (unlikely(r != 0)) {
- DRM_ERROR("Failed to pin framebuffer\n");
+ if (!(r == -EINTR || r == -ERESTARTSYS || r == EAGAIN))
+ DRM_ERROR("Failed to pin framebuffer with error %d\n", r);
return r;
}
</pre>
</blockquote>
<br>
</blockquote>
<p><br>
</p>
</body>
</html>