<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> Hi Lothian<o:p></o:p> <o:p> </o:p> <o:p> </o:p> First of all, thanks for your review. <o:p></o:p> <o:p> </o:p> No, it is the patch which achieve the same function for the issue. But it is the root cause of fence timeout.<o:p></o:p> The patch <a href="https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.16-wip&id=b9141cd3930e390f156739829ca9589fda7926e4">b9141cd3</a> is the word-around for the issue. And I think the varible “shutdown” assignment is better to be located after amdgpu_fini() to ensure no irq miss.<o:p></o:p> <o:p> </o:p> Best Regards<o:p></o:p> Yintian Tao<o:p></o:p> <o:p> </o:p> <o:p> </o:p> From: Mike Lothian [mailto:mike@fireburn.co.uk] Sent: Wednesday, December 13, 2017 7:23 PM To: Tao, Yintian <Yintian.Tao@amd.com> Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Fix no irq process when evict vram<o:p></o:p> <o:p> </o:p> <div> Is this a follow on to <a href="https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.16-wip&id=b9141cd3930e390f156739829ca9589fda7926e4">https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.16-wip&id=b9141cd3930e390f156739829ca9589fda7926e4</a> <o:p></o:p> </div> <o:p> </o:p> <div> <div> On Wed, 13 Dec 2017 at 07:11 Yintian Tao <<a href="mailto:yttao@amd.com">yttao@amd.com</a>> wrote:<o:p></o:p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"> When unload amdgpu driver we use sdma to evict vram but there is no irq process after sdma completed work which raises that waiting for the fence costs 2s which will trigger VFLR under SRIOV and at last make unload driver failed.The reason is that the shutdown varible in adev is set to true before evict vram, it cause ISR directly return without processing.Therefore, we need set the varible after evict vram. Change-Id: I7bf75481aa0744b99c41672b49670adc70b478bd Signed-off-by: Yintian Tao <<a href="mailto:yttao@amd.com" target="_blank">yttao@amd.com</a>> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index a269bbc..80934ee 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -2458,7 +2458,6 @@ void amdgpu_device_fini(struct amdgpu_device *adev) int r; DRM_INFO("amdgpu: finishing device.\n"); - adev->shutdown = true; if (adev->mode_info.mode_config_initialized) drm_crtc_force_disable_all(adev->ddev); @@ -2466,6 +2465,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev) amdgpu_fence_driver_fini(adev); amdgpu_fbdev_fini(adev); r = amdgpu_fini(adev); + adev->shutdown = true; if (adev->firmware.gpu_info_fw) { release_firmware(adev->firmware.gpu_info_fw); adev->firmware.gpu_info_fw = NULL; -- 2.7.4 _______________________________________________ amd-gfx mailing list <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><o:p></o:p> </blockquote> </div> </div> </body> </html>