<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, "EmojiFont", "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Please make sure we only check that register on asics where it is relevant. There are a bunch of VI asics. It should probably be restricted to tonga and fiji only.</p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0">Alex<br> </p> <br> <br> <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> Yu, Xiangliang<br> <b>Sent:</b> Tuesday, December 19, 2017 2:44 AM<br> <b>To:</b> José Pekkarinen<br> <b>Cc:</b> amd-gfx@lists.freedesktop.org; Deucher, Alexander; Koenig, Christian<br> <b>Subject:</b> RE: Topaz mistakenly reported as vf</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">We can add ASIC check in vi_detect_hw_virtualization function to avoid to entry error path.<br> I'll submit patch later.<br> <br> Thanks!<br> <br> > -----Original Message-----<br> > From: José Pekkarinen [<a href="mailto:jose.pekkarinen@canonical.com">mailto:jose.pekkarinen@canonical.com</a>]<br> > Sent: Tuesday, December 19, 2017 3:27 PM<br> > To: Yu, Xiangliang <Xiangliang.Yu@amd.com><br> > Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander<br> > <Alexander.Deucher@amd.com>; Koenig, Christian<br> > <Christian.Koenig@amd.com><br> > Subject: Re: Topaz mistakenly reported as vf<br> > <br> > On Tuesday, 19 December 2017 09:19:02 EET Yu, Xiangliang wrote:<br> > > Topaz doesn't support SRIOV.<br> > ><br> > <br> > Hi Xiangliang,<br> > <br> > Allow me to ask for some attention, as I'm trying to say that given<br> > that Topaz is not having support, amdgpu_sriov_vf(adev) may return false<br> > and ignore the vi.c code path. Instead of it, it enters the code path and<br> > reaches the BUG_ON that states this is not supported.<br> > <br> > Thanks for coming back!<br> > <br> > José.<br> > <br> <br> </div> </span></font></div> </div> </div> </body> </html>