<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, "EmojiFont", "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">I don't think the hwmon interface should expose the units in the string, this will probably break some applications that use the hwmon interface. They are assumed to be milli-degrees celsius as per the API.</p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0">Alex<br> </p> <br> <br> <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Evan Quan <evan.quan@amd.com><br> <b>Sent:</b> Friday, December 29, 2017 2:44 AM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Quan, Evan<br> <b>Subject:</b> [PATCH 1/4] drm/amd/powerplay: show the right unit for the temp printed out</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">Change-Id: I30ea29aa85ab89c0017ecb4e0ab469db5ab5c103<br> Signed-off-by: Evan Quan <evan.quan@amd.com><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 4 ++--<br> 1 file changed, 2 insertions(+), 2 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<br> index 814329b..91f809e 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<br> @@ -789,7 +789,7 @@ static ssize_t amdgpu_hwmon_show_temp(struct device *dev,<br> else<br> temp = amdgpu_dpm_get_temperature(adev);<br> <br> - return snprintf(buf, PAGE_SIZE, "%d\n", temp);<br> + return snprintf(buf, PAGE_SIZE, "%d millicelsius\n", temp);<br> }<br> <br> static ssize_t amdgpu_hwmon_show_temp_thresh(struct device *dev,<br> @@ -805,7 +805,7 @@ static ssize_t amdgpu_hwmon_show_temp_thresh(struct device *dev,<br> else<br> temp = adev->pm.dpm.thermal.max_temp;<br> <br> - return snprintf(buf, PAGE_SIZE, "%d\n", temp);<br> + return snprintf(buf, PAGE_SIZE, "%d millicelsius\n", temp);<br> }<br> <br> static ssize_t amdgpu_hwmon_get_pwm1_enable(struct device *dev,<br> -- <br> 2.7.4<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk967897" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> </div> </span></font></div> </div> </div> </body> </html>