<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
Ok. Thanks. I will query twice.one for pstate sclk and one for mclk.<br>
<br>
Best Regards<br>
Rex
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Deucher, Alexander<br>
<b>Sent:</b> Friday, January 5, 2018 11:44:00 PM<br>
<b>To:</b> Zhu, Rex; amd-gfx@lists.freedesktop.org<br>
<b>Subject:</b> Re: [PATCH 2/2] drm/amd/pp: Add stable Pstate clk display support in debugfs</font>
<div> </div>
</div>
<style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<div style="color:rgb(0,0,0)">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Rex Zhu <Rex.Zhu@amd.com><br>
<b>Sent:</b> Friday, January 5, 2018 6:38 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Zhu, Rex<br>
<b>Subject:</b> [PATCH 2/2] drm/amd/pp: Add stable Pstate clk display support in debugfs</font>
<div> </div>
</div>
<div class="x_BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="x_PlainText">The additional output are: PSTATE_SCLK and PSTATE_MCLK value<br>
in MHz as:<br>
<br>
300 MHz (PSTATE_SCLK)<br>
300 MHz (PSTATE_MCLK)<br>
<br>
Change-Id: I08645d518635f81bc566d242712b6906ee5413fb<br>
Signed-off-by: Rex Zhu <Rex.Zhu@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 ++<br>
drivers/gpu/drm/amd/include/kgd_pp_interface.h | 1 +<br>
drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 8 ++++++++<br>
3 files changed, 11 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<br>
index e5ee7cf..4bd48b1 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<br>
@@ -1512,6 +1512,8 @@ static int amdgpu_debugfs_pm_info_pp(struct seq_file *m, struct amdgpu_device *a<br>
seq_printf(m, "\t%u MHz (MCLK)\n", value/100);<br>
if (!amdgpu_dpm_read_sensor(adev, AMDGPU_PP_SENSOR_GFX_SCLK, (void *)&value, &size))<br>
seq_printf(m, "\t%u MHz (SCLK)\n", value/100);<br>
+ if (!amdgpu_dpm_read_sensor(adev, AMDGPU_PP_SENSOR_STABLE_PSTATE_CLK, (void *)&value, &size))<br>
+ seq_printf(m, "\t%u MHz (PSTATE_SCLK)\n\t%u MHz (PSTATE_MCLK)\n", value & 0xffff, (value>>16) & 0xffff);<br>
if (!amdgpu_dpm_read_sensor(adev, AMDGPU_PP_SENSOR_VDDGFX, (void *)&value, &size))<br>
seq_printf(m, "\t%u mV (VDDGFX)\n", value);<br>
if (!amdgpu_dpm_read_sensor(adev, AMDGPU_PP_SENSOR_VDDNB, (void *)&value, &size))<br>
diff --git a/drivers/gpu/drm/amd/include/kgd_pp_interface.h b/drivers/gpu/drm/amd/include/kgd_pp_interface.h<br>
index 0f89d2a8..1be526f 100644<br>
--- a/drivers/gpu/drm/amd/include/kgd_pp_interface.h<br>
+++ b/drivers/gpu/drm/amd/include/kgd_pp_interface.h<br>
@@ -122,6 +122,7 @@ enum amd_pp_sensors {<br>
AMDGPU_PP_SENSOR_VCE_POWER,<br>
AMDGPU_PP_SENSOR_UVD_POWER,<br>
AMDGPU_PP_SENSOR_GPU_POWER,<br>
+ AMDGPU_PP_SENSOR_STABLE_PSTATE_CLK,<br>
};<br>
<br>
enum amd_pp_task {<br>
diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c<br>
index 8859b67..a0c5642 100644<br>
--- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c<br>
+++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c<br>
@@ -998,6 +998,14 @@ static int pp_dpm_read_sensor(void *handle, int idx,<br>
<br>
hwmgr = pp_handle->hwmgr;<br>
<br>
+ if ((idx == AMDGPU_PP_SENSOR_STABLE_PSTATE_CLK) && (value != NULL)) {<br>
+ mutex_lock(&pp_handle->pp_lock);<br>
+ *((uint32_t *)value) = (hwmgr->pstate_sclk / 100 & 0xffff) |<br>
+ ((hwmgr->pstate_mclk / 100 & 0xffff) << 16);</div>
<div class="x_PlainText"><br>
</div>
<div class="x_PlainText">This seems kinda hacky. Either add two queries or make the query take two values.</div>
<div class="x_PlainText"><br>
</div>
<div class="x_PlainText">Alex<br>
</div>
<div class="x_PlainText"><br>
+ mutex_unlock(&pp_handle->pp_lock);<br>
+ return 0;<br>
+ }<br>
+<br>
if (hwmgr->hwmgr_func->read_sensor == NULL) {<br>
pr_info("%s was not implemented.\n", __func__);<br>
return 0;<br>
-- <br>
1.9.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk796199">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
</div>
</div>
</div>
</body>
</html>