<div dir="ltr"><div><div><div class="gmail_quote"><div dir="ltr">On Mon, Jan 22, 2018 at 1:45 PM Alex Deucher <<a href="mailto:alexdeucher@gmail.com" target="_blank">alexdeucher@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Jan 22, 2018 at 3:20 PM, Drew Davenport <<a href="mailto:ddavenport@google.com" target="_blank">ddavenport@google.com</a>> wrote:<br>
> I was doing some debugging and found that /sys/kernel/debug/dri/0/state<br>
> doesn't get created for amdgpu. After a bit of digging around I found that<br>
> the DRIVER_ATOMIC feature flag gets set in dm_early_init in amdgpu_dm.c,<br>
> which is run after drm_debugfs_init where the atomic debugfs files would<br>
> have been created.<br>
><br>
> I tried moving DRIVER_ATOMIC to the rest of the kms_driver.driver_feature<br>
> flags in amdgpu_drv.c, and this allowed the debugfs to get created as<br>
> expected. Nothing seemed terribly broken, but I didn't test thoroughly.<br>
><br>
> Is there any reason not to move DRIVER_ATOMIC to the rest of the feature<br>
> flags? Thanks.<br>
<br>
It's only available with the new dc modsetting code which doesn't<br>
support all asics so you'd need to selectively enable it depending on<br>
the asic.  You'll only want to enable it if<br>
amdgpu_device_asic_has_dc_<wbr>support() returns true.  I think I had a<br>
patch to do that at one point, but I don't know what I did with it.<br>
<br>
Alex<br></blockquote><div> </div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Right, that makes sense. It looks like this flag could be set according to amdgpu_device_asic_has_dc_</span><wbr style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">support right after the drm_device has been allocated in amdgpu_pci_probe. Would that be a good place to set it?</span><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial">Although, from looking at vi_set_ip_blocks and similar functions, dm_ip_block currently won't get added (and thus DRIVER_ATOMIC won't be set) if virtual display is enabled for some asics. Would it be a problem if DRIVER_ATOMIC is set for those asics even if virtual display is enabled?</div></div></div></div></div></div>