<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">OK I see, but why HMM/ATC/SVN want low 8MB range ? why they cannot use high range address ?</p> <p style="margin-top:0;margin-bottom:0"><br> </p> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Christian König <ckoenig.leichtzumerken@gmail.com><br> <b>Sent:</b> Tuesday, January 23, 2018 4:26:21 PM<br> <b>To:</b> Liu, Monk; He, Roger; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH 3/3] drm/amdgpu: move static CSA address to top of address space</font> <div> </div> </div> <div style="background-color:#FFFFFF"> <div class="x_moz-cite-prefix"> <blockquote type="cite">Any bug introduced by original design ? I don't see why 8MB- 8KB as the start vm address of CSA has any trouble compared with top range ?</blockquote> On gfx9 we need the lower address range (0x0-0x7fffffffffff) for HMM/ATC/SVM. If we map the 8k CSA in there and hit it by accident then the GPU will not do what it is supposed to do :)<br> <br> I could limit the change to only gfx9, but I think the code will be simpler if we change both gfx8 and gfx9.<br> <br> <blockquote type="cite">Besides, please note that you also need modify gfx8/9 source to align emit_cs/de_meta with your change</blockquote> That was the design flaw I was talking about. In other words I couldn't find the code where that address was actually used.<br> <br> We should use the macro define in those functions as well. Going to send fixed for this in a minute.<br> <br> Thanks,<br> Christian.<br> <br> Am 23.01.2018 um 04:23 schrieb Liu, Monk:<br> </div> <blockquote type="cite"><style type="text/css" style="display:none">  </style> <div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif"> <p style="margin-top:0; margin-bottom:0">anyway I prefer no change on that part unless there issues or bug need to fix by the change.</p> <p style="margin-top:0; margin-bottom:0">the CSA address is for use by CPG h/w not s/w, and since 8MB is a reserved range for each VM I don't see</p> <p style="margin-top:0; margin-bottom:0">it's a design flaw with it<br> </p> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Liu, Monk<br> <b>Sent:</b> Tuesday, January 23, 2018 11:20:35 AM<br> <b>To:</b> He, Roger; Christian König; <a class="x_moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org"> amd-gfx@lists.freedesktop.org</a><br> <b>Subject:</b> Re: [PATCH 3/3] drm/amdgpu: move static CSA address to top of address space</font> <div> </div> </div> <style type="text/css" style="display:none">  </style> <div dir="ltr"> <div id="x_x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif"> <p style="margin-top:0; margin-bottom:0">Any bug introduced by original design ? I don't see why 8MB- 8KB as the start vm address of CSA has any trouble compared with top range ? Besides, please note that you also need modify gfx8/9 source to align emit_cs/de_meta with your change</p> <p style="margin-top:0; margin-bottom:0"><br> </p> <p style="margin-top:0; margin-bottom:0"><br> </p> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> He, Roger<br> <b>Sent:</b> Tuesday, January 23, 2018 10:36:31 AM<br> <b>To:</b> Christian König; Liu, Monk; <a class="x_moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org"> amd-gfx@lists.freedesktop.org</a><br> <b>Subject:</b> RE: [PATCH 3/3] drm/amdgpu: move static CSA address to top of address space</font> <div> </div> </div> <div class="x_x_BodyFragment"><font size="2"><span style="font-size:11pt"> <div class="x_x_PlainText"><br> <br> -----Original Message-----<br> From: amd-gfx [<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">mailto:amd-gfx-bounces@lists.freedesktop.org</a>] On Behalf Of Christian K?nig<br> Sent: Monday, January 22, 2018 6:44 PM<br> To: Liu, Monk <a class="x_moz-txt-link-rfc2396E" href="mailto:Monk.Liu@amd.com"><Monk.Liu@amd.com></a>; <a class="x_moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org"> amd-gfx@lists.freedesktop.org</a><br> Subject: [PATCH 3/3] drm/amdgpu: move static CSA address to top of address space<br> <br> There seems to be a design flaw with this since the address of the static CSA is never exported anywhere.<br> <br> Signed-off-by: Christian König <a class="x_moz-txt-link-rfc2396E" href="mailto:christian.koenig@amd.com"> <christian.koenig@amd.com></a><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 15 +++++++-------- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 6 ++++--<br> 2 files changed, 11 insertions(+), 10 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c<br> index e7dfb7b44b4b..c7d24af03e3e 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c<br> @@ -55,11 +55,10 @@ void amdgpu_free_static_csa(struct amdgpu_device *adev) {<br> <br> /*<br> * amdgpu_map_static_csa should be called during amdgpu_vm_init<br> - * it maps virtual address "AMDGPU_VA_RESERVED_SIZE - AMDGPU_CSA_SIZE"<br> - * to this VM, and each command submission of GFX should use this virtual<br> - * address within META_DATA init package to support SRIOV gfx preemption.<br> + * it maps virtual address "AMDGPU_CSA_VADDR" to this VM, and each <br> + command<br> + * submission of GFX should use this virtual address within META_DATA <br> + init<br> + * package to support SRIOV gfx preemption.<br> */<br> -<br> int amdgpu_map_static_csa(struct amdgpu_device *adev, struct amdgpu_vm *vm,<br> struct amdgpu_bo_va **bo_va)<br> {<br> @@ -90,7 +89,7 @@ int amdgpu_map_static_csa(struct amdgpu_device *adev, struct amdgpu_vm *vm,<br> return -ENOMEM;<br> }<br> <br> - r = amdgpu_vm_alloc_pts(adev, (*bo_va)->base.vm, AMDGPU_CSA_VADDR,<br> + r = amdgpu_vm_alloc_pts(adev, (*bo_va)->base.vm, <br> +AMDGPU_CSA_VADDR(adev),<br> AMDGPU_CSA_SIZE);<br> if (r) {<br> DRM_ERROR("failed to allocate pts for static CSA, err=%d\n", r); @@ -99,9 +98,9 @@ int amdgpu_map_static_csa(struct amdgpu_device *adev, struct amdgpu_vm *vm,<br> return r;<br> }<br> <br> - r = amdgpu_vm_bo_map(adev, *bo_va, AMDGPU_CSA_VADDR, 0, AMDGPU_CSA_SIZE,<br> - AMDGPU_PTE_READABLE | AMDGPU_PTE_WRITEABLE |<br> - AMDGPU_PTE_EXECUTABLE);<br> + r = amdgpu_vm_bo_map(adev, *bo_va, AMDGPU_CSA_VADDR(adev), 0,<br> + AMDGPU_CSA_SIZE, AMDGPU_PTE_READABLE |<br> + AMDGPU_PTE_WRITEABLE | AMDGPU_PTE_EXECUTABLE);<br> <br> if (r) {<br> DRM_ERROR("failed to do bo_map on static CSA, err=%d\n", r); diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h<br> index 6a83425aa9ed..499362b55e45 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h<br> @@ -251,8 +251,10 @@ struct amdgpu_virt {<br> uint32_t gim_feature;<br> };<br> <br> -#define AMDGPU_CSA_SIZE (8 * 1024)<br> -#define AMDGPU_CSA_VADDR (AMDGPU_VA_RESERVED_SIZE - AMDGPU_CSA_SIZE)<br> +#define AMDGPU_CSA_SIZE (8 * 1024)<br> +#define AMDGPU_CSA_VADDR(adev) \<br> + (((adev)->vm_manager.max_pfn << AMDGPU_GPU_PAGE_SHIFT) + \<br> + AMDGPU_VA_RESERVED_SIZE)<br> <br> If I understand your intention correctly, it should be that: <br> + (((adev)->vm_manager.max_pfn << AMDGPU_GPU_PAGE_SHIFT) - \<br> + AMDGPU_VA_RESERVED_SIZE)<br> <br> Thanks<br> Roger(Hongbo.He)<br> <br> #define amdgpu_sriov_enabled(adev) \<br> ((adev)->virt.caps & AMDGPU_SRIOV_CAPS_ENABLE_IOV)<br> --<br> 2.14.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> <a class="x_moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> </div> </span></font></div> </div> </blockquote> <br> </div> </body> </html>