<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, "EmojiFont", "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;" dir="ltr"> <p style="margin-top:0;margin-bottom:0"><br> </p> <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Oded Gabbay <oded.gabbay@gmail.com><br> <b>Sent:</b> Wednesday, January 31, 2018 10:17 AM<br> <b>To:</b> Kuehling, Felix<br> <b>Cc:</b> amd-gfx list<br> <b>Subject:</b> Re: [PATCH 7/9] drm/amdkfd: Add dGPU support to kernel_queue_init</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">On Fri, Jan 5, 2018 at 12:17 AM, Felix Kuehling <Felix.Kuehling@amd.com> wrote:<br> > Recognize dGPU ASIC families.<br> ><br> > Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com><br> > ---<br> > drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 5 +++++<br> > 1 file changed, 5 insertions(+)<br> ><br> > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c b/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c<br> > index 5dc6567..69f4964 100644<br> > --- a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c<br> > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c<br> > @@ -297,10 +297,15 @@ struct kernel_queue *kernel_queue_init(struct kfd_dev *dev,<br> ><br> > switch (dev->device_info->asic_family) {<br> > case CHIP_CARRIZO:<br> > + case CHIP_TONGA:<br> > + case CHIP_FIJI:<br> > + case CHIP_POLARIS10:<br> > + case CHIP_POLARIS11:<br> I believe POLARIS is from arcatic islands, no ?<br> Maybe rename kernel_queue_init_vi to kernel_queue_init_vi_ai ?<br> or create a new function kernel_queue_init_ai() and assign same<br> functions as vi ?<br> Either way, I think you need to address that.</div> <div class="PlainText"><br> </div> <div class="PlainText">They are all gfx8. adding ai just confuses things. </div> <div class="PlainText"><br> </div> <div class="PlainText">Alex<br> </div> <div class="PlainText"><br> <br> > kernel_queue_init_vi(&kq->ops_asic_specific);<br> > break;<br> ><br> > case CHIP_KAVERI:<br> > + case CHIP_HAWAII:<br> > kernel_queue_init_cik(&kq->ops_asic_specific);<br> > break;<br> > default:<br> > --<br> > 2.7.4<br> ><br> <br> Other then that, This patch is:<br> Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com><br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk943420" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> </div> </span></font></div> </div> </div> </body> </html>