<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, "EmojiFont", "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br> </p> <br> <br> <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Tom St Denis <tom.stdenis@amd.com><br> <b>Sent:</b> Tuesday, February 6, 2018 2:09 PM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> StDenis, Tom<br> <b>Subject:</b> [PATCH] drm/amd/powerplay: Zero out power data in AMDGPU_PP_SENSOR_GPU_POWER readout</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">Since 12 of the 16 bytes are not initialized with anything let's ensure they're<br> sensibly zeroed out otherwise debugfs callers will read back garbage<br> (because they assume debugfs wrote sensible data back...)<br> <br> Signed-off-by: Tom St Denis <tom.stdenis@amd.com><br> ---<br> drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 ++<br> 1 file changed, 2 insertions(+)<br> <br> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br> index 5e3c63f8b62a..341fba5f7171 100644<br> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br> @@ -3889,7 +3889,9 @@ static int vega10_get_gpu_power(struct pp_hwmgr *hwmgr,<br> return -EINVAL);<br> <br> vega10_read_arg_from_smc(hwmgr, &value);<br> +<br> /* power value is an integer */<br> + memset(query, 0, sizeof *query);<br> query->average_gpu_power = value << 8;<br> <br> return 0;<br> -- <br> 2.14.3<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk487226" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> </div> </span></font></div> </div> </div> </body> </html>